[linux-dvb] Driver question of dvb_frontend.c

[Falck Kenneth <kennu@swelcom.fi>]

Hi,

I've been reviewing the driver code lately. Looking at dvb_frontend.c I see
this:

>static int
>fe_fail(dvb_front_t *fe)
>{
>        FrontendEvent ev;
>
>        fe->tuning=FE_STATE_IDLE;
>        ev.type=FE_FAILURE_EV;
>        fe_add_event(&fe->events, &ev);
>
>        return -1;
>}

I'm not a really driver guy, but doesn't this mean, that the FrontendEvent
is allocated on the stack, and is thus random data?

Should there be something like:

ev.u.failureEvent = 0;
demod_command(fe, FE_READ_STATUS, &ev.u.failureEvent);

before adding the event to the queue?

-- 
Kenneth Falck      SWelcom Oy
R&D Manager        Ludviginkatu 6-8 
+358 40 5103121    00130 Helsinki, Finland


-- 
Info:
To unsubscribe send a mail to listar@linuxtv.org with "unsubscribe linux-dvb" as subject.