Mailing List archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[linux-dvb] warnings when making apps/test



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

hi,

i've fixed some files in apps/test, to build them without warnings..
the main thing was the missing #include <string.h> in some files..

the other thing was the:
"comparison between signed and unsigned"
and the
"signed and unsigned type in conditional expression"

in video.c

the reason is the definition in linux/videodev.h ..

'struct video_window' is '__u32' for 'width,height'
but
'struct video_capability' is 'int' for 'maxwidth' and 'maxheight'

also there was #include <stdlib.h> missing for the 'exit' function in line
175..

i will append a diff that someone with CVS-write-access can easy fix
this..

i know, these are no really problems, but i like build processes without
any warnings.. and beneath testing and using, all i can do is to fix such
minor "problems".. i hope someone can understand me..

joerg

now the diff:

diff -u DVB/apps/test/sendburst.c DVB_MOD/apps/test/sendburst.c
- --- DVB/apps/test/sendburst.c   Fri Oct 11 19:11:08 2002
+++ DVB_MOD/apps/test/sendburst.c       Fri Oct 11 19:05:25 2002
@@ -6,6 +6,7 @@

 #include <stdlib.h>
 #include <stdio.h>
+#include <string.h>
 #include <unistd.h>
 #include <sys/ioctl.h>
 #include <sys/types.h>
diff -u DVB/apps/test/set22k.c DVB_MOD/apps/test/set22k.c
- --- DVB/apps/test/set22k.c      Fri Oct 11 19:11:08 2002
+++ DVB_MOD/apps/test/set22k.c  Fri Oct 11 19:05:25 2002
@@ -8,6 +8,7 @@

 #include <stdlib.h>
 #include <stdio.h>
+#include <string.h>
 #include <unistd.h>
 #include <sys/ioctl.h>
 #include <sys/types.h>
diff -u DVB/apps/test/setvoltage.c DVB_MOD/apps/test/setvoltage.c
- --- DVB/apps/test/setvoltage.c  Fri Oct 11 19:11:08 2002
+++ DVB_MOD/apps/test/setvoltage.c      Fri Oct 11 19:05:25 2002
@@ -8,6 +8,7 @@

 #include <stdlib.h>
 #include <stdio.h>
+#include <string.h>
 #include <unistd.h>
 #include <sys/ioctl.h>
 #include <sys/types.h>
diff -u DVB/apps/test/test_sec_ne.c DVB_MOD/apps/test/test_sec_ne.c
- --- DVB/apps/test/test_sec_ne.c Fri Oct 11 19:11:08 2002
+++ DVB_MOD/apps/test/test_sec_ne.c     Fri Oct 11 19:05:25 2002
@@ -21,6 +21,7 @@

 #include <stdio.h>
 #include <stdlib.h>
+#include <string.h>
 #include <unistd.h>
 #include <sys/types.h>
 #include <sys/stat.h>
diff -u DVB/apps/test/test_sections.c DVB_MOD/apps/test/test_sections.c
- --- DVB/apps/test/test_sections.c       Fri Oct 11 19:11:08 2002
+++ DVB_MOD/apps/test/test_sections.c   Fri Oct 11 19:05:25 2002
@@ -21,6 +21,7 @@

 #include <stdio.h>
 #include <stdlib.h>
+#include <string.h>
 #include <unistd.h>
 #include <sys/types.h>
 #include <sys/stat.h>
diff -u DVB/apps/test/video.c DVB_MOD/apps/test/video.c
- --- DVB/apps/test/video.c       Fri Oct 11 19:11:08 2002
+++ DVB_MOD/apps/test/video.c   Fri Oct 11 19:05:25 2002
@@ -17,6 +17,8 @@
 #include <fcntl.h>
 #include <signal.h>
 #include <stdio.h>
+#include <stdlib.h>
+#include <string.h>

 #include <linux/fb.h>
 #include <linux/videodev.h>
@@ -132,8 +134,8 @@

        {
                struct video_window win;
- -               win.width = min( vcap.maxwidth, fb_var.xres );
- -               win.height = min( vcap.maxheight, fb_var.yres );
+               win.width = min( (__u32)vcap.maxwidth, fb_var.xres );
+               win.height = min( (__u32)vcap.maxheight, fb_var.yres );
                win.x = 0;
                win.y = 0;
                win.flags = 0;


end of diff
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE9pwr6SPOsGF+KA+MRAlY9AJ4sNKzoHeNCI02KSPUJqm4e06UhZACeKs6Z
dLOibez3XhspOCyo+D7lXrc=
=e5CG
-----END PGP SIGNATURE-----




-- 
Info:
To unsubscribe send a mail to listar@linuxtv.org with "unsubscribe linux-dvb" as subject.



Home | Main Index | Thread Index