[linux-dvb] Re: mini patch to grundig_29504-491.c

[Holger Waechtler <holger@convergence.de>]

Wolfgang Thiel wrote:
> I'll attach a mini patch to grundig_29504-491.c.
> I cannot check whether the returned values are correct now, because
> I don't have such a frontend here.
oops, this should be tda8083_readreg(i2c, 0x0e) & 0x07...

The highorder bit contains the spectrum inversion setting, so I just 
removed the bogus out-of-range check -- index is limited to the range of 
0...7 due to the &= ~0x07 statement anyway.

thanks for reviewing the code,

Holger

> ------------------------------------------------------------------------
>
> --- grundig_29504-491.c.orig	2003-06-23 20:35:12.000000000 +0200
> +++ grundig_29504-491.c	2003-06-23 20:37:53.000000000 +0200
> @@ -187,7 +187,7 @@
>  	static fe_code_rate_t fec_tab [] = { FEC_8_9, FEC_1_2, FEC_2_3, FEC_3_4,
>  				       FEC_4_5, FEC_5_6, FEC_6_7, FEC_7_8 };
>  
> -	index = tda8083_readreg (i2c, 0x0e) & 0x3;
> +	index = tda8083_readreg (i2c, 0x0e);
>  
>  	if (index > 7)
>  		return FEC_NONE;


--
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe linux-dvb" as subject.