Mailing List archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[linux-dvb] Re: [PATCH] Skystar2 pid filters reorganization



Roberto Ragusa wrote:
Hi,

this patch reorganizes the hw filter in skystar2.c to avoid many similar
functions. I also tried to raise the artificial limit of 0x27 simulated
filters to 60 (there is a #define now).

I'm not still sure about how to handle the group/mask filter, hence a
couple of "#ifdef 0" in the code.

I don't see any regression, and I expect some improvements because of the
0x27->60 change (but "scan" behaviour is not improved too much).

This patch is not ready for CVS. I only want some feedback about it
(do you experience problems?).
Well, please don't get me wrong, it's always a good thing to have people improving the code. But after taking a look at your changes, I'd vote not to have them fed to CVS. I'm rather a OO-supporter, but doing too much OO style in a device driver is too much: Your changes give a rather small improvement in readability but reduce the execution speed further (more arguments passed -> less speed).

Again, please don't get this wrong, I'm not trying a personal attack - it's just my opinion towards how a device driver should look.

Btw.: I think you're right about the 0x3fff issue.

Niklas



--
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe linux-dvb" as subject.



Home | Main Index | Thread Index