[linux-dvb] Re: [PATCH] Ultra Light Encapsulation

[Holger Waechtler <holger@qanu.de>]

Michael Hunold wrote:

> Hello Hilmar,
>
> On 03/31/04 11:11, Hilmar Linder wrote:
> [...]
>
> > diff -ru linuxtv-dvb-apps-1.1.0/include/linux/dvb/net.h 
> > linuxtv-dvb-apps-1.1.0-ULE/include/linux/dvb/net.h
> > --- linuxtv-dvb-apps-1.1.0/include/linux/dvb/net.h    2004-01-17 
> > 17:59:46.000000000 +0100
> > +++ linuxtv-dvb-apps-1.1.0-ULE/include/linux/dvb/net.h    2004-03-30 
> > 11:36:33.000000000 +0200
> > @@ -30,6 +30,9 @@
> >  struct dvb_net_if {
> >      __u16 pid;
> >      __u16 if_num;
> > +    __u8 feedtype;
> > +#define FEEDTYPE_SEC    0
> > +#define FEEDTYPE_TS        1
> >  };
> [...]
>
> While preparing a new patchset for the 2.6 kernel, it just came to my 
> mind that this is a binary incompatible change to the Linux DVB v3 API.
it's binary-backwards-compatible but new applications using this feature 
might not won't with old drivers. So I'd say it's safe, we extended the 
API like this before. I'd suggest to add a note in the API docs which 
suggests to preinitialize this field to the old default setting to 
ensure defined behaviour.

In doubt an application can simply test the API sub-version at compile 
time by checking the existence of the FEEDTYPE_XXX #defines.

Holger



--
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe linux-dvb" as subject.