Mailing List archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[linux-dvb] Re: AverMedia DVB-T 771 problems



The mt352.c at the URL you provided appears to be incorrect. I submitted
a patch last week but Wolfgang apparently hasn't integrated it yet. The
shifts in mt352_set_parameters are all completely wrong. I have attached
a slightly modified version that works for me here in Canberra. I have
been using an AverMedia DVB-T 771 for a week now with MythTV, absolutely
perfect reception for all stations. It is a good card.

For reference, the correct values are documented on page 38 of the MT352
Design Manual in the TPS_GIVEN table.

    http://assets.zarlink.com/DM/MT352_Design_Manual_Nov03.pdf

PS: also for your info, http://www.dba.org.au/ has frequencies for all
Australian DVB-T transmitters, including all regions in Tasmania.


On Tue, 2004-06-15 at 05:33 +1000, Jolse Maginnis wrote:
> Hi,
> 
> I've purchased an AverMedia DVB-T 771, and I live in Tasmania,
> Australia, but I can't seem to get it to tune anything in linux. It
> works in winxp (I can tune nearly all the channels with my crap
> aerial), so it's got to be the driver.
> 
> I'm using the patches from
> http://www.frokaschwei.net/avtv771/avermedia.html
> and they appear to work better than what's in cvs, but all I get when I
> try using tzap is something like:
> 
> ./tzap -c channels.conf-dvbt-australia "Ten Digital"
> 
> status 13 | signal 8b8b | snr 7474 | ber 00000000 | unc 00000000 | FE_HAS_LOCK
> status 13 | signal 8383 | snr 7c7c | ber 00000000 | unc 00000000 | FE_HAS_LOCK
> status 13 | signal 8383 | snr 7c7c | ber 00000000 | unc 00000000 | FE_HAS_LOCK
> status 13 | signal 8b8b | snr 7474 | ber 00000000 | unc 00000000 | FE_HAS_LOCK
> status 13 | signal 8b8b | snr 7474 | ber 00000000 | unc 00000000 | FE_HAS_LOCK
> status 13 | signal 8b8b | snr 7474 | ber 00000000 | unc 00000000 | FE_HAS_LOCK
> 
> I know that the frequency is correct because i noted the frequencies for 
> the channels in windows.
> 
> I did some exploring in mt352.c and managed to get the mt352 to scan for 
> channels, but there was no luck. But what was more disturbing was that status 
> registers appeared to be not being read properly.
> 
> In mt352.c the code that checks the status of the signal:
> 
> 	case FE_READ_STATUS:
> 		status = arg;
> 		*status = 0;
> 		r = mt352_read_register (i2c, 0x00);
> 		if (r & (1 << 4))
> 			*status = FE_HAS_CARRIER;
> 		if (r & (1 << 1))
> 			*status |= FE_HAS_VITERBI;
> 		if (r & (1 << 5))
> 			*status |= FE_HAS_LOCK;
> 
> 		r = mt352_read_register (i2c, 0x01);
> 		if (r & (1 << 1))
> 			*status |= FE_HAS_SYNC;
> 
> 		r = mt352_read_register (i2c, 0x03);
> 		if (r & (1 << 6))
> 			*status |= FE_HAS_SIGNAL;
> 		
> 		break;
> 
> if i add:
> 		r = mt352_read_register (i2c, 0x7f);
> before:
> 		r = mt352_read_register (i2c, 0x00);
> the read of register 0x00 returns the same as the read of register 0x7f!
> And it appears that the "snr" values from above are actually the value of register 0x03!
> 
> Very strange indeed..
> 
> Can anybody shed any light on this problem? 
> I'm running 2.6.7-rc3 with a Pentium4 2.8ghz.
> 
> Jolse
> 
> 
> 
/* 
 *  Driver for Zarlink DVB-T MT352 demodulator
 *
 *  Written by Holger Waechtler <holger@qanu.de> 
 *	 and Daniel Mack <daniel@qanu.de>
 *
 *  AVerMedia AVerTV DVB-T 771 support by 
 *       Wolfram Joost <dbox2@frokaschwei.de>
 *
 *  This program is free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
 *  the Free Software Foundation; either version 2 of the License, or
 *  (at your option) any later version.
 *
 *  This program is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *
 *  GNU General Public License for more details.
 *
 *  You should have received a copy of the GNU General Public License
 *  along with this program; if not, write to the Free Software
 *  Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.=
 */    

#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/init.h>
#include <linux/delay.h>

#include "dvb_frontend.h"

#define I2C_MT352_ADDR 0x0f
#define I2C_TUNER_ADDR 0xc2

#define CARD_UNKNOWN	0x00
#define CARD_AVDVBT771	0x01

#define mt352_write(ibuf, ilen)						\
do {									\
	struct i2c_msg msg = { .addr = I2C_MT352_ADDR, .flags = 0,	\
			       .buf = ibuf, .len = ilen };		\
	int err = i2c->xfer(i2c, &msg, 1);				\
	if (err != 1) {							\
		printk(KERN_WARNING 					\
		       "mt352_write() failed (err = %d)!\n", err);	\
		return err;						\
	}								\
} while (0)


#define msb(x) (((x) >> 8) & 0xff)
#define lsb(x) ((x) & 0xff)

static struct dvb_frontend_info mt352_info = {
	.name 			= "DVB-T Zarlink MT352 demodulator driver",
	.type 			= FE_OFDM,
	.frequency_min 		= 174000000,
	.frequency_max 		= 862000000,
	.frequency_stepsize 	= 166667,
/*
	.frequency_tolerance 	= 0,
	.symbol_rate_min 	= 1000000,
	.symbol_rate_max 	= 45000000,
	.symbol_rate_tolerance 	= ???,
*/
	.notifier_delay		 = 0,
	.caps = FE_CAN_INVERSION_AUTO | FE_CAN_FEC_1_2 | FE_CAN_FEC_2_3 | 
		FE_CAN_FEC_3_4 | FE_CAN_FEC_5_6 | FE_CAN_FEC_7_8 |
		FE_CAN_FEC_AUTO |
		FE_CAN_QPSK | FE_CAN_QAM_16 | FE_CAN_QAM_64 | FE_CAN_QAM_AUTO |
		FE_CAN_TRANSMISSION_MODE_AUTO | FE_CAN_GUARD_INTERVAL_AUTO |
		FE_CAN_HIERARCHY_AUTO | FE_CAN_RECOVER | 
		FE_CAN_MUTE_TS
};

int mt352_detect_avermedia_771(struct dvb_i2c_bus *i2c)
{
	u8 reg;
	u8 id[4];
	const u8 pciid[4] = { 0x07, 0x71, 0x14, 0x61 };
	struct i2c_msg msg[2] = { {
				.addr = 0x50,
				.flags = I2C_M_NOSTART,
				.buf = &reg,
				.len = 1
			       },
			       {
				.addr = 0x50,
				.flags = I2C_M_RD,
				.len = 1
			       }
			     };
	int i;

	for (i = 0; i < 4; i++)
	{
		reg = i + 0xFC;
		msg[1].buf = id + i;
		if (i2c->xfer(i2c,msg,2) != 2)
		{
			return 0;
		}
	}

	return *((u32 *) id) == *((u32 *) pciid);
}

int mt352_init (struct dvb_i2c_bus *i2c, u32 card_type, u8 attach)
{
	/**
	 *  all register write sequence have the register address of the
	 *  first register in the first byte, thenafter the value to write
	 *  into this and the following registers.
	 */
	static u8 mt352_reset_attach [] = { 0x50, 0xC0 };
	static u8 mt352_reset [] = { 0x50, 0x80 };
	static u8 mt352_clock_config [] = { 0x89, 0x38, 0x2d };
	static u8 mt352_adc_ctl_1_cfg [] = { 0x8e, 0x40 };
	static u8 mt352_agc_cfg [] = { 0x67, 0x19, 0xa0 };
	static u8 mt352_acq_ctl [] = { 0x53, 0x50 };

	static u8 mt352_agc_cfg_av771 [] = { 0x67, 0x10, 0x23, 0x00, 0xFF, 0xFF, 0x00, 0xFF, 0x00, 0x40, 0x40 };
	#if 0
	static u8 mt352_clock_config_av771 [] = { 0x89, 0x30, 0x2d };
	#endif
	static u8 mt352_av771_extra[] = { 0xB5, 0x7A };
	/**
	 *  We only write non-default settings, all default settings are
	 *  restored by the full mt352_reset sequence.
	 */
	if (attach)
	{
		mt352_write(mt352_reset_attach,sizeof(mt352_reset_attach));
	}
	#if 0
	if (card_type == CARD_AVDVBT771)
	{
		mt352_write(mt352_clock_config_av771, sizeof(mt352_clock_config_av771));
	}
	else
	{
	#endif
		mt352_write(mt352_clock_config, sizeof(mt352_clock_config));
	#if 0
	}
	#endif
	udelay(2000);
	mt352_write(mt352_reset, sizeof(mt352_reset));
	mt352_write(mt352_adc_ctl_1_cfg, sizeof(mt352_adc_ctl_1_cfg));
	mt352_write(mt352_acq_ctl, sizeof(mt352_acq_ctl));
	if (card_type == CARD_AVDVBT771)
	{
		mt352_write(mt352_agc_cfg_av771,sizeof(mt352_agc_cfg_av771));
		udelay(2000);
		mt352_write(mt352_av771_extra,sizeof(mt352_av771_extra));
	}
	else
	{

		/**
		 *  The optimal AGC target value and slope might vary from tuner
		 *  type to tuner type, so check whether you need to adjust this one...
		 */
		mt352_write(mt352_agc_cfg, sizeof(mt352_agc_cfg));
	}

	return 0;
}


int mt352_set_parameters (struct dvb_i2c_bus *i2c,
			  struct dvb_frontend_parameters *param, u32 card_type)
{
	unsigned char buf[14];
	unsigned int tps = 0;
	struct dvb_ofdm_parameters *op = &param->u.ofdm;
	u32 freq = param->frequency / 1000;
	uint16_t tmp;

	switch (op->code_rate_HP) {
		case FEC_2_3:
			tps |= (1 << 7);
			break;
		case FEC_3_4:
			tps |= (2 << 7);
			break;
		case FEC_5_6:
			tps |= (3 << 7);
			break;
		case FEC_7_8:
			tps |= (4 << 7);
			break;
		case FEC_AUTO:
			break;
		default:
			;
	}

	switch (op->code_rate_LP) {
		case FEC_2_3:
			tps |= (1 << 4);
			break;
		case FEC_3_4:
			tps |= (2 << 4);
			break;
		case FEC_5_6:
			tps |= (3 << 4);
			break;
		case FEC_7_8:
			tps |= (4 << 4);
			break;
		case FEC_AUTO:
			break;
		default:
			;
	}

	switch (op->constellation) {
		case QAM_16:
			tps |= (1 << 13);
			break;
		case QAM_64:
			tps |= (2 << 13);
			break;
		default:
			;
	}

	switch (op->transmission_mode) {
		case TRANSMISSION_MODE_8K:
			tps |= (1 << 0);
			break;
		default:
			;
	}

	switch (op->guard_interval) {
		case GUARD_INTERVAL_1_16:
			tps |= (1 << 2);
			break;
		case GUARD_INTERVAL_1_8:
			tps |= (2 << 2);
			break;
		case GUARD_INTERVAL_1_4:
			tps |= (3 << 2);
			break;
		default:
			;
	}
	
	switch (op->hierarchy_information) {
		case HIERARCHY_1:
			tps |= (1 << 10);
			break;
		case HIERARCHY_2:
			tps |= (2 << 10);
			break;
		case HIERARCHY_4:
			tps |= (3 << 10);
			break;
		default:
			;
	}


	buf[0] = 0x51; /* TPS_GIVEN_1 and following registers */

	buf[1] = msb(tps);      /* TPS_GIVEN_(1|0) */
	buf[2] = lsb(tps);

// 	buf[3] = 0xf3;  /* ACQ_CTL, force parameters, automatic spectral inv */
	buf[3] = 0x50;  /* ACQ_CTL, fully automatic parameter search */

	/**
	 *  these settings assume 20.48MHz f_ADC, for other tuners you might
	 *  need other values. See p. 33 in the MT352 Design Manual.
	 */
	if (op->bandwidth == BANDWIDTH_8_MHZ) {
		buf[4] = 0x72;  /* TRL_NOMINAL_RATE_(1|0) */
		buf[5] = 0x49;
	} else if (op->bandwidth == BANDWIDTH_7_MHZ) {
		buf[4] = 0x64;
		buf[5] = 0x00;
	} else {		/* 6MHz */
		buf[4] = 0x55;
		buf[5] = 0xb7;
	}

	buf[8] = I2C_TUNER_ADDR;

	/**
	 *  All the following settings are tuner module dependent,
	 *  check the datasheet...
	 */
	{
		/* here we assume 1/6MHz == 166.66kHz stepsize */
		#define IF_FREQUENCYx6 217    /* 6 * 36.16666666667MHz */
		tmp = (6 * freq) / 1000 + IF_FREQUENCYx6;
		buf[9] = msb(tmp);      /* CHAN_START_(1|0) */
		buf[10] = lsb(tmp);
	}

	if (card_type == CARD_AVDVBT771)
	{
		printk(KERN_DEBUG "setting parameters for 771\n");
		buf[6] = 0xF1;
		buf[7] = 0x06;

		if (freq < 150000)
		{
			buf[11] = 0xB4;
			buf[12] = 0x01;
		}
		else if (freq < 173000)
		{
			buf[11] = 0xBC;
			buf[12] = 0x01;
		}
		else if (freq < 250000)
		{
			buf[11] = 0xB4;
			buf[12] = 0x02;
		}
		else if (freq < 400000)
		{
			buf[11] = 0xBC;
			buf[12] = 0x02;
		}
		else if (freq < 420000)
		{
			buf[11] = 0xF4;
			buf[12] = 0x02;
		}
		else if (freq < 470000)
		{
			buf[11] = 0xFC;
			buf[12] = 0x02;
		}
		else if (freq < 600000)
		{
			buf[11] = 0xBC;
			buf[12] = 0x08;
		}
		else if (freq < 730000)
		{
			buf[11] = 0xF4;
			buf[12] = 0x08;
		}
		else
		{
			buf[11] = 0xFC;
			buf[12] = 0x08;
		} 
	}
	else
	{
		buf[6] = 0x31;  /* INPUT_FREQ_(1|0), 20.48MHz clock, 36.166667MHz IF */
		buf[7] = 0x05;  /* see MT352 Design Manual page 32 for details */

		printk (KERN_WARNING "buf9,10: %02x %02x\n", buf[9], buf[10]);
	
		if (freq < 542000)
			buf[11] = 0xbe; /* CONT_1, charge pump byte */
		else if (freq < 830000)
			buf[11] = 0xf6;
		else
			buf[11] = 0xfe;

		if (freq < 250000)	 /* VHF, freq < 250MHz */
			buf[12] = 0x01; /* CONT_0, bandswitch byte */
		else
			buf[12] = 0x08;
	}

	buf[13] = 0x01; /* TUNER_GO!! */

	mt352_write(buf, sizeof(buf));
	
	return 0;
}


static u8 mt352_read_register (struct dvb_i2c_bus *i2c, u8 reg)
{
	int ret;
	u8 b0 [] = { reg };
	u8 b1 [] = { 0 };
	struct i2c_msg msg [] = { { .addr = I2C_MT352_ADDR,
				    .flags = I2C_M_NOSTART,
				    .buf = b0, .len = 1 },
				  { .addr = I2C_MT352_ADDR,
				    .flags = I2C_M_RD,
				    .buf = b1, .len = 1 } };

	ret = i2c->xfer (i2c, msg, 2);

	if (ret != 2)
		printk(KERN_WARNING
		       "%s: readreg error (ret == %i)\n", __FUNCTION__, ret);

	return b1[0];
}


static int mt352_dump (struct dvb_i2c_bus *i2c) {
	int i;

	for (i=0x00; i<=0x26; i++)
		printk("mt352[%03x]: %02x\n", i, mt352_read_register (i2c, i));
	for (i=0x50; i<=0x7f; i++)
		printk("mt352[%03x]: %02x\n", i, mt352_read_register (i2c, i));
	
	return 0;
}


static int mt352_ioctl (struct dvb_frontend *fe, unsigned int cmd, void *arg)
{
	struct dvb_i2c_bus *i2c = fe->i2c;
	u32 card_type = (u32) fe->data;
	int i;

	switch (cmd) {
	case FE_GET_INFO:
		memcpy (arg, &mt352_info, sizeof(struct dvb_frontend_info));
		break;

	case FE_READ_STATUS:
	{
		u8 r;
		fe_status_t *status = arg;
		*status = 0;

		r = mt352_read_register (i2c, 0x0);
		if (r & (1 << 5))
			*status |= FE_HAS_LOCK;
		if (r & (1 << 4))
			*status |= FE_HAS_CARRIER;
		if (r & (1 << 1))
			*status |= FE_HAS_VITERBI;

		r = mt352_read_register (i2c, 0x1);
		if (r & (1 << 1))
			*status |= FE_HAS_SYNC;
		
		r = mt352_read_register (i2c, 0x3);
		if (r & (1 << 6))
			*status |= FE_HAS_SIGNAL;

/*		mt352_dump(i2c); */
		break;
	}

	case FE_READ_BER:
	{
		u32 *ber = (u32 *) arg;
		*ber = (mt352_read_register (i2c, 0xA) << 16) |
		       (mt352_read_register (i2c, 0xB) << 8) |
		       (mt352_read_register (i2c, 0xC));
		break;
	}

	case FE_READ_SIGNAL_STRENGTH:
	{
		u16 signal = (mt352_read_register (i2c, 0x12) << 8) |
			     (mt352_read_register (i2c, 0x13));
		*((u16*) arg) = ~signal;
		break;
	}

	case FE_READ_SNR:
	{
		u8 snr = mt352_read_register (i2c, 0x9);
		*(u16*) arg = (snr << 8) | snr;
		break;
	}

	case FE_READ_UNCORRECTED_BLOCKS:
		*(u32*) arg = (mt352_read_register (i2c, 0x10) << 8) |
			      (mt352_read_register (i2c, 0x11));
		break;

	case FE_SET_FRONTEND:
		i = mt352_set_parameters (i2c,
				 (struct dvb_frontend_parameters *) arg,card_type);
/*		mt352_dump(i2c); */
		return i;

	case FE_GET_FRONTEND:
		break;

	case FE_SLEEP:
		return 0;

	case FE_INIT:
		return mt352_init(i2c,card_type,0);

	default:
		return -EOPNOTSUPP;
	}

	return 0;
} 


static int mt352_attach (struct dvb_i2c_bus *i2c, void **data)
{
	u32 card_type;

	if (mt352_read_register(i2c, 0x7f) == 0x13)
	{
		if (mt352_detect_avermedia_771(i2c))
		{
			card_type = CARD_AVDVBT771;
		}
		else
		{
			card_type = CARD_UNKNOWN;
		}
		mt352_init(i2c,card_type,1);
		return dvb_register_frontend(mt352_ioctl, i2c, (void *) card_type,
					     &mt352_info);
	}
	
	return -ENODEV;
}


static void mt352_detach (struct dvb_i2c_bus *i2c, void *data)
{
	dvb_unregister_frontend(mt352_ioctl, i2c);
}


static int __init init_mt352 (void)
{
	return dvb_register_i2c_device(NULL, mt352_attach, mt352_detach);
}


static void __exit exit_mt352 (void)
{
	dvb_unregister_i2c_device(mt352_attach);
}


module_init(init_mt352);
module_exit(exit_mt352);


MODULE_DESCRIPTION("DVB-T MT352 Zarlink");
MODULE_AUTHOR("Holger Waechtler, Daniel Mack");
MODULE_LICENSE("GPL");


Home | Main Index | Thread Index