[linux-dvb] Re: mt352 and SkyStar2 (FlexCop IIB) oddities

[Wolfram Joost <dvbmailing@frokaschwei.de>]

Hi,

> Attached is a patch against CVS that makes software I2C work, as well as
> implementing the second policy.

I had a closer look to your patch:

+	unsigned char acqctl = 0x0B;	/* suggest spectral inversion on, force mode, 
guard */

I think it should be set to 0x5B. If the FE looses the lock it should recover. 
Maybe one doesn't catch some wrong parameters but I think recovery is more 
importent.


 	switch (op->code_rate_HP/LP/constellation/hierarchy) {
..
 		case FEC_AUTO:
+			acqctl |= (15 << 4);	/* all parameters auto */

Hmm, I think (5 << 4) is a better setting. But setting acqctl to 0x5B makes 
this unnecessary.

Finaly I don't think we should disable all the recovery-functions just to 
catch some wrong parameters.

Wolfram