[linux-dvb] Re: Proposal for new frontend architecture

[Andrew de Quincey <adq_dvb@lidskialf.net>]

On Monday 20 Sep 2004 17:58, Michael Hunold wrote:
> Hi,
>
> On 16.09.2004 13:40, Andrew de Quincey wrote:
> > --- linux-2.6.9-rc1/include/linux/i2c.h 2004-08-29 17:31:47.000000000
> > +0100 +++ linux-2.6.9-rc1.adqpatch/include/linux/i2c.h 2004-09-16
> > 12:37:42.341385984 +0100 @@ -230,6 +230,12 @@
> >   unsigned int class;
> >   struct i2c_algorithm *algo;/* the algorithm to access the bus */
> >   void *algo_data;
> > + unsigned int flags;
> > +
> > + /* a ioctl like command that can be used to perform specific functions
> > +  * with the adapter.
> > +  */
> > + int (*command)(struct i2c_client *client,unsigned int cmd, void *arg);
>
> Shouldn't the first argument be a struct i2c_adapter * instead?
>
> In our particular case for sure, because in the probe function we don't
> have a valid i2c_client. Instead, if we query some specific thing from
> the device the i2c adapter is hanging on, most likely the private
> pointer holds the device data.
>
> If you agree with this change, I'll sent it off to Greg K-H and LKML and
> see if it is accepted.

yeah - that sounds fine.

> The flag stuff should be separated from this.

I'll send you a new patch with it separated out.