[linux-dvb] Re: refactoring

[Gerd Knorr <kraxel@bytesex.org>]

Andrew de Quincey <adq_dvb@lidskialf.net> writes:

> > I don't think it is useful.  If I look at the cx22702 fe code for
> > example I don't see how trying to replace cx22702_ioctl() with
> > something generic + function pointer hooks would improve things.  Most
> > of the code is just mapping dvb api enums+defines to hardware specific
> > values and visa versa, that isn't something which can be shared with
> > other frontend drivers ...
> 
> But it allows the other frontends which do need card specific functions to be 
> implemented in a much more flexible manner. The cx22702 on the hardware we 
> have doesn't need that admittedly,

cx22702 actually does that (well, at least the version in my cvs), it
has a function pointer in cx22702_state for setting the PLL.  It's a
nice thing, yes, as it keeps the hardware-specific setup in _one_
place (the initialization code where you setup the function pointers)
instead of having "switch (card-type)" everythere.  But you don't need
a ioctl layer to do that.  I still doubt that is a good idea to do
that.

  Gerd

-- 
return -ENOSIG;