[linux-dvb] Re: refactoring

[John Dalgliesh <johnd@defyne.org>]

On Mon, 11 Oct 2004, Andrew de Quincey wrote:
>
> I think having separate pll_ops/pll_priv is going a bit far - they're just too
> simple. Its unlikely they can ever be shared really.

I don't know if they can be shared, but...

JohnsDualG4:frontends johnd$ grep sp5659 *.c
alps_tdlb7.c:static int sp5659_write (struct i2c_adapter *i2c, u8 data [4])
alps_tdlb7.c:static void sp5659_set_tv_freq (struct i2c_adapter *i2c, u32 freq)
alps_tdlb7.c:   sp5659_write (i2c, buf);
alps_tdlb7.c:   sp5659_set_tv_freq (i2c, p->frequency);
nxt6000.c:static int sp5659_set_tv_freq(struct nxt6000_config *nxt, u32 freq)
nxt6000.c:                              if ((result = sp5659_set_tv_freq(fe, param->frequency)) < 0)
ves1820.c:              printk("ves1820: setup for tuner sp5659c\n");
ves1x93.c:static int sp5659_set_tv_freq (struct i2c_adapter *i2c, u32 freq)
ves1x93.c:              return sp5659_set_tv_freq (i2c, freq);

Just did it out of interest... (and that was the first one I tried)

{P^/