[linux-dvb] Re: Oops with (cvs) ttusb-dec and 2.6.10-rc1

[Nyk Tarr <nyk@giantx.co.uk>]

On Tue, Nov 09, 2004 at 10:45:12PM +0000, Nyk Tarr wrote:
> On Tue, Nov 09, 2004 at 06:02:46AM +0000, Andrew de Quincey wrote:
> > 
> > > Nov  6 17:57:40 natsu kernel: Call Trace:
> > > Nov  6 17:57:40 natsu kernel: [<f9bc3eac>] dvb_frontend_init+0x1c/0x50
> > > [dvb_core]
> > > Nov  6 17:57:40 natsu kernel: [<f9bc431c>]
> > > dvb_frontend_thread+0x8c/0x480 [dvb_core]
> > > Nov  6 17:57:40 natsu kernel: [<c01156d5>] schedule_tail+0x15/0x50
> > > Nov  6 17:57:40 natsu kernel: [<c0103cbe>] ret_from_fork+0x6/0x14
> > > Nov  6 17:57:40 natsu kernel: [<f9bc4290>] dvb_frontend_thread+0x0/0x480
> > > [dvb_core]
> > > Nov  6 17:57:40 natsu kernel: [<f9bc4290>] dvb_frontend_thread+0x0/0x480
> > > [dvb_core]
> > > Nov  6 17:57:40 natsu kernel: [<c010227d>] kernel_thread_helper+0x5/0x18
> > > Nov  6 17:57:40 natsu kernel: Code:  Bad EIP value.
> > >
> > > Any ideas?
> > 
> > Fixed - give CVS HEAD a go now
> 
> Thanks, I'll try as soon as I've replaced the graphics card that's
> just broke on me -_-

Sorted now.

Great, it's working fine, however, it's still complaining about

==
Nov 11 18:43:36 natsu kernel: usb_unlink_urb() is deprecated for synchronous unlinks.  Use usb_kill_urb() instead.
...
==

The patch attached fixes it, compiles and runs, but I have no idea if
_all_ the usb_unlink_urb() s need to be changed.


Ta very,
Nyk
-- 
/__
\_|\/
   /\
diff -Nur dvb-kernel/linux/drivers/media/dvb/ttusb-dec/ttusb_dec.c dvb-kernel-20041111/linux/drivers/media/dvb/ttusb-dec/ttusb_dec.c
--- dvb-kernel/linux/drivers/media/dvb/ttusb-dec/ttusb_dec.c	2004-10-28 20:05:44.000000000 +0100
+++ dvb-kernel-20041111/linux/drivers/media/dvb/ttusb-dec/ttusb_dec.c	2004-11-11 18:46:35.000000000 +0000
@@ -759,7 +759,7 @@
 
 	if (!dec->iso_stream_count) {
 		for (i = 0; i < ISO_BUF_COUNT; i++)
-			usb_unlink_urb(dec->iso_urb[i]);
+			usb_kill_urb(dec->iso_urb[i]);
 	}
 
 	up(&dec->iso_sem);
@@ -824,7 +824,7 @@
 				       "error %d\n", __FUNCTION__, i, result);
 
 				while (i) {
-					usb_unlink_urb(dec->iso_urb[i - 1]);
+					usb_kill_urb(dec->iso_urb[i - 1]);
 					i--;
 				}
 
@@ -1386,7 +1386,7 @@
 	dec->iso_stream_count = 0;
 
 	for (i = 0; i < ISO_BUF_COUNT; i++)
-		usb_unlink_urb(dec->iso_urb[i]);
+		usb_kill_urb(dec->iso_urb[i]);
 
 	ttusb_dec_free_iso_urbs(dec);
 }