[linux-dvb] Re: [PATCH] dvb-ttpci+budgetpatch integrated v22

[Johannes Stezenbach <js@linuxtv.org>]

Hi,

emard@softhome.net wrote:
> Naming of dvbnet devices is fixed, they are
> now called dvb000 for net0 and dvb010 for net1
> ("_" in the middle of dvb0_0 is used to indicate
> id of net* interface)

Please don't do that. There is not need to, is there?
I guess that would break various scripts.

> For CVS
> -------------------------------
> dvb-ttpci is extended with second demux on 
> port B of 7146, named demux1, 
> with accompanying net1 and dvr1 devices.
> 
> This allows full ts data transmission running in 
> parallel with all prior functions of dvb-s.
> Runs on dvb-s 1.x with budget patch and dvb-s >=2.1
> perhaps without any modification if those cards 
> are manufactured with divider chips onboard.
> 
> For unmodified 1.X cards this patch is a no-op.
> demux1 exists but receives no data.

IMHO that's not acceptable. If you can't probe for the presence
of the hardware support for demux1 you need to have a
module parameter to enable it.

> Naming convention of dvb0_0 has to be changed
> to dvb000, middle digit indicating net0 and
> dvb010 for net1.

The naming convention must not be change for compatibility
reasons. Maybe dvb_net -l can be changed to display netX number?

Some coding style issues:
- don't mix tabs and spaces (you do it in a few places)
- don't add #if 0'ed code without a comment why it needs to be there
- please use the usual block comment style not you special one

Johannes