[vdr] Bug in vdr.c for syslogd ( vdr-1.1.20)

[Dimitrios Dimitrakos <mail@dimitrios.de>]

Hi,


VDR Manual say :

Set logging to level. 0 = no logging, 1 = errors only, 2 = errors and 
info, 3 = errors, info and debug. The
default logging level is 3. If logging should be done to LOG_LOCALn 
instead of LOG_USER, add '.n' to LEVEL, as in
3.7 (n=0..7).


The bug is :

         case 'l': {
                     char *p = strchr(optarg, '.');
                     if (p)
                        *p = 0;
                     if (isnumber(optarg)) {
                        int l = atoi(optarg);
                        if (0 <= l && l <= 3) {
                           SysLogLevel = l;
                           if (!p)
                              break;
                           if (isnumber(p + 1)) {
*******               int l = atoi(optarg);    
                              if (0 <= l && l <= 7) {
                                 int targets[] = { LOG_LOCAL0, 
LOG_LOCAL1, LOG_LOCAL2, LOG_LOCAL3, LOG_LOCAL4, LOG_LOCAL5, LOG_LOCAL6, 
LOG_LOCAL7 };
                                 SysLogTarget = targets[l];
                                 break;
                                 }
                              }
                           }
                        }
                   if (p)
                      *p = '.';
                   fprintf(stderr, "vdr: invalid log level: %s\n", optarg);
                   return 2;
                   }
                   break;
.
.
.
After the check if (isnumber(p + 1)) {

int l must set to atoi( p+1 );

         case 'l': {

                     char *p = strchr(optarg, '.');
                     if (p)
                        *p = 0;
                     if (isnumber(optarg)) {

                        int l = atoi(optarg);
                        if (0 <= l && l <= 3) {
                           SysLogLevel = l;
                           if (!p)
                              break;
                           if (isnumber(p + 1)) {
                              int l = atoi( p+1 );
                              if (0 <= l && l <= 7) {
                                 int targets[] = { LOG_LOCAL0, 
LOG_LOCAL1, LOG_LOCAL2, LOG_LOCAL3, LOG_LOCAL4, LOG_LOCAL5, LOG_LOCAL6, 
LOG_LOCAL7 };
                                 SysLogTarget = targets[l];
                                 break;
                                 }
                              }
                           }
                        }
                   if (p)
                      *p = '.';
                   fprintf(stderr, "vdr: invalid log level: %s\n", optarg);
                   return 2;
                   }
                   break;


Greeting
Dimitri





--
Info:
To unsubscribe send a mail to listar@linuxtv.org with "unsubscribe vdr" as subject.