[vdr] Re: RE : Re: Implementing new device into a plugin :

[Klaus Schmidinger <Klaus.Schmidinger@cadsoft.de>]

Philippe wrote:
> 
> Hi,
> Thanks for your answer Klaus but there is something I still don't
> understand (you didn't answer my question)

I didn't go into details regarding this because it will very soon be
changed. Maybe you can wait until then...

> Well here is what I do not understand :
> 
> Here are the cDvbDevice::PlayVideo/Audio method :
> 
> int cDvbDevice::PlayVideo(const uchar *Data, int Length)
> {
>   int fd = (playMode == pmAudioOnly || playMode == pmAudioOnlyBlack) ?
> fd_audio : fd_video;
>   if (fd >= 0)
>     return write(fd, Data, Length);
>   return -1;
> }
> 
> In this function which is designed to play some video stuff I cannot
> figure out why there is any reference to fd_audio. Could you explain it
> to me ?

The PlayVideo() function actually plays video _and_ audio. So the name
of that function is badly chosen (mea culpa). I am going to change this
into a (properly named ;-) function that accepts the complete data stream
(video, audio, AC3, subtitles, whatever) and distributes it to the proper
individual functions, which a derived cDevice class can implement.

> void cDvbDevice::PlayAudio(const uchar *Data, int Length)
> {
>   //XXX actually this function will only be needed to implement
> replaying AC3 over the DVB card's S/PDIF
>   cDevice::PlayAudio(Data, Length);
> }
> 
> Why is this method not used to play the current audio track (only to
> play AC3 stream)?

That's one of the things I'm planning to change.

> >There will be a few changes in that area before the final version
> 1.2.0.
> >Basically the cDevice will get _one_ function that receives the entire
> data
> >stream to be replayed, and will parse that stream and send the various
> >audio/video/whatever packets to the appropriate functions of the actual
> >device (through virtual functions).
> 
> So when do you plan to make this new design released to the public ? it
> should be easier to create new devices

As soon as it's finished ;-) Sorry, I can't give you a concrete date.

Klaus
-- 
_______________________________________________________________

Klaus Schmidinger                       Phone: +49-8635-6989-10
CadSoft Computer GmbH                   Fax:   +49-8635-6989-40
Hofmark 2                               Email:   kls@cadsoft.de
D-84568 Pleiskirchen, Germany           URL:     www.cadsoft.de
_______________________________________________________________


-- 
Info:
To unsubscribe send a mail to listar@linuxtv.org with "unsubscribe vdr" as subject.