[vdr] Re: [PATCH] Old descriptorhandling with vdr 1.2.5

["Reinhard Walter Buchner" <rw.buchner@freenet.de>]

Hi Tilo, Onno, esp Martin,

> Hi ML,
>
> I've attached a patch for vdr 1.2.5 (maybe it works for vdr < 1.2.5)

The problem with your patch is that it changes *too* many things at
once. You'll never be able to pinpoint the source of the problem that
way.

You now have to start re-inserting the changes made by Klaus, one
by one to see where the actual error occurs.

E.g.: your patched changes

- case RI_CONDITIONAL_ACCESS_SUPPORT: newCaSupport = true;
- return sessions[i] = new cCiConditionalAccessSupport(i + 1, tc);
+ case RI_CONDITIONAL_ACCESS_SUPPORT: return sessions[i] = new
cCiConditionalAccessSupport(i + 1, tc);
case RI_HOST_CONTROL: break; //XXX
case RI_DATE_TIME: return sessions[i] = new cCiDateTime(i + 1, tc);
case RI_MMI: return sessions[i] = new cCiMMI(i + 1, tc);
@@ -1491,8 +1476,6 @@
UserIO |= sessions[i]->HasUserIO();
}
hasUserIO = UserIO;
- if (newCaSupport)
- newCaSupport = result = false; // triggers new SetCaPmt at caller!

The only thing that has changed here is that newCaSupport is set to true
and below a new SetCaPmt is triggered. Here you should revert to Klaus'
original routine and simply set the newCaSupport to false. That way, the
routine below isn't called. Analogous for the other changes. The way you
patched it we have no idea if the problem results from the ci.c handling
or the eit processor or if it's just a simple change like calling the
ProgramID instead of the ServiceID in cSIProcessor::NewCaDescriptor.

Also I would leave all variables, which are simply being defined and
initialzed out of the patch. Sure, you'll get a few warnings about unused
variables, but who cares in a debugging situation? This will help make
the changes more visible.

My 02 cents.

Greets,
Reinhard


---
Outgoing mail is certified Virus Free.
Checked by AVG anti-virus system (http://www.grisoft.com).
Version: 6.0.512 / Virus Database: 309 - Release Date: 19.08.2003



-- 
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe vdr" as subject.