[vdr] Re: VDR developer version 1.3.0

[Klaus Schmidinger <Klaus.Schmidinger@cadsoft.de>]

Robert Schiele wrote:
> 
> On Sun, Jan 04, 2004 at 06:56:36PM +0200, Lauri Tischler wrote:
> > There is a great number of warnings like :
> > config.h:91: warning: `bool cConfig<T>::Load(const char*, bool, bool) [with
> > T =
> >    cSetupLine]' was hidden
> > config.h:246: warning:   by `bool cSetup::Load(const char*)'
> 
> The signature of virtual funtion Load() in some sub classes is incompatible to
> the one in the super class.  This patch should fix this.
> ...

I'll rather just remove the 'virtual' from the Load functions,
since there's no real need for it:

--- channels.h  2004/01/04 12:26:37     1.10
+++ channels.h  2004/01/05 10:06:15
@@ -156,7 +156,7 @@
   int beingEdited;
 public:
   cChannels(void);
-  virtual bool Load(const char *FileName, bool AllowComments = false, bool MustExist = false);
+  bool Load(const char *FileName, bool AllowComments = false, bool MustExist = false);
   int GetNextGroup(int Idx);   // Get next channel group
   int GetPrevGroup(int Idx);   // Get previous channel group
   int GetNextNormal(int Idx);  // Get next normal channel (not group)
--- config.h    2004/01/05 09:56:54     1.179
+++ config.h    2004/01/05 10:05:57
@@ -87,7 +87,7 @@
   cConfig(void) { fileName = NULL; }
   virtual ~cConfig() { free(fileName); }
   const char *FileName(void) { return fileName; }
-  virtual bool Load(const char *FileName = NULL, bool AllowComments = false, bool MustExist = false)
+  bool Load(const char *FileName = NULL, bool AllowComments = false, bool MustExist = false)
   {
     Clear();
     if (FileName) {

Klaus


-- 
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe vdr" as subject.