[vdr] Re: VDR developer version 1.3.6

[Marcel Wiesweg <marcel.wiesweg@gmx.de>]

Am Sonntag, 25. April 2004 12:23 schrieb Prakash K. Cheemplavam:
> Hi,
>
> I just tried to make a quick compilation fix for gcc3.4. I am not sure,
> whether the fixes are right, so please take a look and then merge. It
> compiles, but I have not done a test-run.

Here is another tested suggestion.
The first is a matter of taste - in their changelog however, the propose to 
use "this->" for members of dependent base classes in dependent classes.

The second is because cast-as-lvalue is no longer accepted. A cast of the 
rvalue is maybe the more straightforward solution.

And btw a note to early adopters: Don't dare to compile the DVB drivers or 
your kernel with gcc 3.4 if your kernel is as old as 2.4.20 (in my case).
The module version in the modules will be stripped by gcc (not 
referenced ;-) ) and insmod will refuse to load the module.
Solution: The -fno-unit-at-a-time switch or a recent kernel.

diff -U 2 vdr-1.3.6/config.h ./config.h
--- vdr-1.3.6/config.h  Fri Mar  5 15:35:15 2004
+++ ./config.h  Thu Apr 22 22:59:08 2004
@@ -139,5 +139,5 @@
   {
     bool result = true;
-    T *l = (T *)First();
+    T *l = (T *)this->First();
     cSafeFile f(fileName);
     if (f.Open()) {
Common subdirectories: vdr-1.3.6/libsi and ./libsi
diff -U 2 vdr-1.3.6/plugin.c ./plugin.c
--- vdr-1.3.6/plugin.c  Sat Aug 30 16:52:58 2003
+++ ./plugin.c  Thu Apr 22 22:23:39 2004
@@ -163,5 +163,5 @@
   if (!error) {
      void *(*creator)(void);
-     (void *)creator = dlsym(handle, "VDRPluginCreator");
+     creator = (void *(*)(void))dlsym(handle, "VDRPluginCreator");
      if (!(error = dlerror()))
         plugin = (cPlugin *)creator();



-- 
Info:
To unsubscribe send a mail to ecartis@linuxtv.org with "unsubscribe vdr" as subject.