[vdr] OSD and patterns

[Jouni Karvo <kex@netlab.hut.fi>]

hello,

I was carried away a bit on the pattern stuff of the emails today and
looked at your osd source.  It seems to me that the cOsdProvider class
is meant to control creation of the actual cOsd classes.  However,
currently the constructors of cOsd and sDvbOsd are public, so it is a
possible place for a future bug. (If I understood correctly.) I suggest
that those methods would be made protected and the cOsdProvider class
made a friend.

Another thing that came to my mind is to use the proxy pattern as an
intelligent pointer for cOsd so that the user of the OSD would not
need to take care of explicitly deleting it but it would be deleted
automatically whenever no-one has a pointer to it any more.  I'm not
sure if this is the best thing to do in this case, but if you are
interested, I could try to find time to provide a patch for it.

(sorry about the new thread - I already lost the original and did not
find the necessary info from linuxtv.org archive)

yours,
		Jouni