Mailing List archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[vdr] Re: VDR developer version 1.3.14
Stefan Huelswitt wrote:
>
> On 24 Oct 2004 Klaus Schmidinger <Klaus.Schmidinger@cadsoft.de> wrote:
>
> > - Added some checks when cancelling a thread and removed the usleep() in
> > cThread::Start() (suggested by Ludwig Nussel). Also removed 'running' from
> > cThread and using only childTid to indicate whether a thread is actually
> > running.
>
> Although the changes improves a lot, I think the code isn't 100%
> tight. childTid is accessed from 2 threads and should be
> protected by a mutex to be save.
>
> Should I prepare a patch?
I don't think that this is necessary.
childTid is an integral variable and thus read or written "as a whole".
I don't see any danger here - but if you can come up with a scenario
where there could be a problem, I might stand corrected.
Klaus
Home |
Main Index |
Thread Index