[linux-dvb] Bug in VIDEO_SET_DISPLAY_FORMAT

Rami Rasanen raipe at neutech.fi
Wed Apr 6 19:31:35 CEST 2005


On Wed, 6 Apr 2005, Rami Rasanen wrote:

> Hello!
> 
> I found a bug from ttpci/av7110_av.c:
> 
> The requested "panscan"-type is incorrectly set into 
> av7110->videostate.video_format. As far as I understand, 
> av7110->videostate.video_format should contain the aspect ratio of 
> the currently played video stream.
> 
> After setting preferred screen clipping type with 
> VIDEO_SET_DISPLAY_FORMAT, VIDEO_GET_STATUS reports 
> wrong aspect ratio until next aspect ratio change.

Sorry for rushing with the patch. I noticed that there are display_format 
member in struct video_status, so I think the original intention of the 
code was to set it.

Here's a fixed patch:


*** dvb-kernel-old/linux/drivers/media/dvb/ttpci/av7110_av.c    Wed Apr  6 19:46:28 2005
--- dvb-kernel/linux/drivers/media/dvb/ttpci/av7110_av.c        Wed Apr  6 20:26:51 2005
***************
*** 1075,1081 ****
                }
                if (ret < 0)
                        break;
!               av7110->videostate.video_format = format;
                ret = av7110_fw_cmd(av7110, COMTYPE_ENCODER, SetPanScanType,
                                    1, (u16) val);
                break;
--- 1075,1081 ----
                }
                if (ret < 0)
                        break;
!               av7110->videostate.display_format = format;
                ret = av7110_fw_cmd(av7110, COMTYPE_ENCODER, SetPanScanType,
                                    1, (u16) val);
                break;


-- 
Rami Räsänen
raipe at neutech.fi




More information about the linux-dvb mailing list