[linux-dvb] pcHDTV HD2000 card (ATSC) driver

Gerd Knorr kraxel at bytesex.org
Fri Feb 18 09:59:09 CET 2005


Johannes Stezenbach <js at linuxtv.org> writes:

> > /* log10-1 table at .5 increments from 1 to 100.5 */
> > unsigned int i100x20log10[] = {
> > unsigned int denom[] = {1,1,100,1000,10000,100000,1000000,10000000,100000000};

> > unsigned int i20Log10(unsigned short val)

> This is kind of neat, but since none of the other frontends does it
> I ask myself if we should either drop it, or factor it out into
> dvb_frontend.c so the other frontends could use it, too.

Factor out please.  I have patches pending for HD3000 (cx88 based)
with that in there as well, so we'll have at least two users of that,
which is enougth to satisfy a helper function in common code IMHO ;)

> > 	msleep(3); /* 30ms */
> 
> hmm

search+replace bug I guess ;)
That used to be "some_hand_crafted_sleep_func(3) /* 30ms */".

  Gerd

-- 
#define printk(args...) fprintf(stderr, ## args)




More information about the linux-dvb mailing list