[linux-dvb] Re: [REVISED -mm PATCH] v4l: add dvb support for dvico fusionhdtv3 gold-T

Mac Michaels wmichaels1 at earthlink.net
Wed Jul 6 00:35:51 CEST 2005


On Tuesday 05 July 2005 05:07 pm, Michael Krufky wrote:
>
> Johannes-
>
> The correct lines are ALREADY in kconfig:
>
> +config DVB_LGDT3302
> ... and the same for OR51132, CX22702, MT352, etc...
>
> All this really does is rename the "HAVE_LGDT3302" to
> "CONFIG_DVB_LGDT3302" -- In the past, the symbol was
> sitting there doing nothing, NOW it actually means
> something.  This doesn't affect any of the boards in the
> linuxtv tree... It only affects the boards in the v4l
> tree.  In addition, the makefile in video4linux cvs
> automatically selects every frontend to be built.
>
> Do you still think it's a bad idea?  I think that it is
> the correct way to do things.  I don't think we need to
> assume that a user doesn't know anything.  If a user is
> going to recompile his/her kernel, they need to know what
> chips to give support to.  Default kernels should have
> all options selected as modules, so IMHO, this shouldn't
> cause problems for too many people.
>
> We are trying to reduce the dependency of v4l on dvb.  If
> you still cannot agree to this, then I can add the
> following to the top of cx88-dvb (to restore old behavior
> of blindly including every frontend), but I would rather
> not:
>
> +#define CONFIG_DVB_CX22702 1
> +#define CONFIG_DVB_OR51132 1
> +#define CONFIG_DVB_LGDT3302 1
> +#define CONFIG_DVB_MT352 1
>
> Basically, all i effectively did is remove those four
> lines and renamed the symbols to make sense.  What do you
> think?

I like your fix Michael. I prefer to have only the stuff I 
use in my kernel. That is one reason I use gentoo. It is 
likely to be appreciated by embeded systems builders too as 
they do not want to include unused software in their build.

-- Mac




More information about the linux-dvb mailing list