[linux-dvb] finally two more patches againts dvb-apps

Ludwig Nussel ludwig.nussel at suse.de
Wed Jul 6 09:05:17 CEST 2005


Johannes Stezenbach wrote:
> Matthias Schwarzott wrote:
> > The next two patches against dvb-apps CVS change the following:
> > The first corrects the makefiles to not abort when doing make install.
> > 
> > The second makes them respect the user's CFLAGS variable.
> 
> Both patches comitted. Overriding CFLAGS only works via environment,
> "make CFLAGS=foo" doesn't. I don't think that's important, though.

Well, at least I normally use that method :-) It breaks atm because
you put stuff in to CFLAGS that should probably go into CPPFLAGS,
e.g.:

Index: dvb-apps/lib/libdvbcfg/Makefile
===================================================================
--- dvb-apps.orig/lib/libdvbcfg/Makefile
+++ dvb-apps/lib/libdvbcfg/Makefile
@@ -16,7 +16,7 @@ INCLUDES = 	dvbcfg_source.h \
 		dvbcfg_common.h \
 		dvbcfg_multiplex.h
 
-CFLAGS += -I. -I../../include
+CPPFLAGS = -I. -I../../include
 
 LIB = libdvbcfg.a
 RANLIB = ranlib

With all the Makefile mess, did you already consider using Automake?

Btw libdvbcfg is scary. It produces tons of warnings (implicit
declaration, format string type mismatch, wrong return etc). Is
anyone working on fixing that?

cu
Ludwig

-- 
 (o_   Ludwig Nussel
 //\   SUSE LINUX Products GmbH, Development
 V_/_  http://www.suse.de/




More information about the linux-dvb mailing list