[linux-dvb] finally two more patches againts dvb-apps

Ludwig Nussel ludwig.nussel at suse.de
Wed Jul 6 12:37:09 CEST 2005


Johannes Stezenbach wrote:
> Ludwig Nussel wrote:
> > Johannes Stezenbach wrote:
> > > Matthias Schwarzott wrote:
> > > > The next two patches against dvb-apps CVS change the following:
> > > > The first corrects the makefiles to not abort when doing make install.
> > > > 
> > > > The second makes them respect the user's CFLAGS variable.
> > > 
> > > Both patches comitted. Overriding CFLAGS only works via environment,
> > > "make CFLAGS=foo" doesn't. I don't think that's important, though.
> > 
> > Well, at least I normally use that method :-) It breaks atm because
> > you put stuff in to CFLAGS that should probably go into CPPFLAGS,
> > e.g.:
> 
> Do you suggest I should back out the patch? Or is someone
> sending an update patch?

I'll send any fixes needed.

> > With all the Makefile mess, did you already consider using Automake?
> 
> No, not for a microsecond.

There are no shared libraries, no gettext and AFAIK no exotic build
rules in dvb-apps so the Makefile.am's and configure.in should be
small and simple. Would you accept a patch for this? (Note: the
always wrong or missing CFLAGS and broken install targets are a PITA
as well :-))

cu
Ludwig

-- 
 (o_   Ludwig Nussel
 //\   SUSE LINUX Products GmbH, Development
 V_/_  http://www.suse.de/




More information about the linux-dvb mailing list