[linux-dvb] finally two more patches againts dvb-apps

Ludwig Nussel ludwig.nussel at suse.de
Thu Jul 7 11:20:27 CEST 2005


Andrew de Quincey wrote:
> On Wednesday 06 July 2005 11:43, Andrew de Quincey wrote:
> > On Wednesday 06 July 2005 11:24, Ludwig Nussel wrote:
> > > Andrew de Quincey wrote:
> > > > > Btw libdvbcfg is scary. It produces tons of warnings (implicit
> > > > > declaration, format string type mismatch, wrong return etc). Is
> > > > > anyone working on fixing that?
> > > >
> > > > Eh? it compiles cleanly here with no warnings. What compiler/switches
> > > > are you using? I'm using gcc 3.4.4
> > >
> > > gcc 4 here but 3.3 also warns you if you compile with -Wall
> >
> > Cool - I'll sort that out tonight. I should just enable -Wall by default
> > anyway.
> 
> Done - it should compile cleanly now with -Wall. Let me know of any more 
> problems.

Much better now :-) CFLAGS need to be fixed though:

Index: dvb-apps/lib/libdvbcfg/Makefile
===================================================================
--- dvb-apps.orig/lib/libdvbcfg/Makefile
+++ dvb-apps/lib/libdvbcfg/Makefile
@@ -16,7 +16,8 @@ INCLUDES = 	dvbcfg_source.h \
 		dvbcfg_common.h \
 		dvbcfg_multiplex.h
 
-CFLAGS += -I. -I../../include -Wall -Wstrict-prototypes -Wshadow -Wpointer-arith
+CFLAGS ?= -O2 -g -Wall -Wstrict-prototypes -Wshadow -Wpointer-arith
+CPPFLAGS = -I. -I../../include
 
 LIB = libdvbcfg.a
 RANLIB = ranlib

dvbcfg_diseqc.c: In function 'dvbcfg_diseqc_save':
dvbcfg_diseqc.c:149: warning: 'polarization' may be used uninitialized in this function
dvbcfg_vdrchannel.c: In function 'dvbcfg_vdrchannel_load':
dvbcfg_vdrchannel.c:161: warning: control may reach end of non-void function 'parse_fe_setting' being inlined
dvbcfg_zapchannel.c: In function 'dvbcfg_zapchannel_save':
dvbcfg_zapchannel.c:378: warning: 'polarization' may be used uninitialized in this function
dvbcfg_multiplex.c: In function 'dvbcfg_multiplex_save':
dvbcfg_multiplex.c:706: warning: 'polarization' may be used uninitialized in this function
dvbcfg_multiplex.c: In function 'dvbcfg_multiplex_calculate_differentiator':
dvbcfg_multiplex.c:1356: warning: 'tmp' may be used uninitialized in this function
dvbcfg_multiplex.c: In function 'dvbcfg_multiplex_load':
dvbcfg_multiplex.c:149: warning: 'newmultiplex' may be used uninitialized in this function

cu
Ludwig

-- 
 (o_   Ludwig Nussel
 //\   SUSE LINUX Products GmbH, Development
 V_/_  http://www.suse.de/




More information about the linux-dvb mailing list