[linux-dvb] twinhan bttv hang bug in kernel 2.6.13

[Michael Krufky]

Manu Abraham wrote:

>>>>> It seems to me as if this bug has resurfaced again. I had no 
>>>>> problems loading bttv with my twinhan VP1030A with the 2.6.12 
>>>>> kernel (actually patched for gentoo-sources, but I don't think 
>>>>> there were any bttv related patches). When trying to upgrade to 
>>>>> either 2.6.13-rc3 or 2.6.13-rc3-mm1 I was getting a hang when 
>>>>> loading bttv, both from the kernel vedeo4linux tree and from the 
>>>>> latest cvs (18/7/2005). I applied the patch Manu posted months ago 
>>>>> from 
>>>>> http://www.linuxtv.org/pipermail/linux-dvb/attachments/20050404/00967085/bttv-cards.c-0001.bin 
>>>>> to the video4linux cvs source compiled againt 2.6.13-rc3-mm1 and 
>>>>> the problem was fixed.
>>>>>
>>>>> Just thought that anyone else crawling this list for fixed might 
>>>>> want to know. Did the fix not make it into the video4linux cvs 
>>>>> tree ? (the patch applied cleanly) 
>>>>
>>> There is a better patch. It probably got lost because it was
>>> applied to the kernel which v4l was maintainer- and CVS-less.
>>
>> Any idea whether the i2c timing patch also got lost ?
>
> It seems only the bttv_reset_audio bugfix only got lost. But that went 
> mainline too, IIRC, maybe never got back to v4l CVS ..

Looks like it's been taken out of 2.6.13 ... probably an accidental 
regression... When I have time later on I will send this over to 
Andrew.  For now, I just applied this to video4linux cvs:  (ignore the 
ugly whitespace issues... it's because I cut&pasted from a web 
browser... spacing in cvs is clean.)

Tue Jul 19 18:26:46 2005 UTC (2 minutes, 47 seconds ago) by mkrufky
        * bttv-cards.c:
        - Fix Bug 4395: modprobe bttv freezes the computer
          http://bugme.osdl.org/show_bug.cgi?id=4395.
          Date: Wed, 13 Apr 2005 03:20:08
          Patch by Manu Abraham and Gerd Knorr:
        - Remove redundant bttv_reset_audio() which caused the computer to
          freeze with some bt8xx based DVB cards when loading the bttv 
driver.

        This patch must have gotten lost during the orphaned v4l days...

        Signed-off-by: Johannes Stezenbach <js at linuxtv.org>
        Signed-off-by: Andrew Morton <akpm at osdl.org>
        Signed-off-by: Michael Krufky <mkrufky at m1k.net>

===================================================================
RCS file: /cvs/video4linux/video4linux/bttv-cards.c,v
retrieving revision 1.53
retrieving revision 1.54
diff -u -r1.53 -r1.54
--- video4linux/bttv-cards.c    2005/07/05 17:37:35    1.53
+++ video4linux/bttv-cards.c    2005/07/19 18:26:46    1.54
@@ -1,5 +1,5 @@
 /*
-    $Id: bttv-cards.c,v 1.53 2005/07/05 17:37:35 nsh Exp $
+    $Id: bttv-cards.c,v 1.54 2005/07/19 18:26:46 mkrufky Exp $
 
     bttv-cards.c
 
@@ -2813,8 +2813,6 @@
         }
     btv->pll.pll_current = -1;
 
-    bttv_reset_audio(btv);
-
     /* tuner configuration (from card list / autodetect / insmod option) */
      if (UNSET != bttv_tvcards[btv->c.type].tuner_type)
         if(UNSET == btv->tuner_type)


-- 
Michael Krufky