[linux-dvb] DViCO FusionHDTV& lgdt330x support plans

Michael Krufky mkrufky at m1k.net
Wed Jul 20 08:24:12 CEST 2005


Mac Michaels wrote:

>1) Remove the dvb_pll_desc from the frontend and replace with 
>a pll_set-callback to isolate the tuner programming from 
>the frontend.
>
>2) Select the RF input connector based upon the type of 
>demodulation selected. ANT RF connector is selected for 
>8-VSB and CABLE RF connector is selected for QAM64/QAM256. 
>Implement this along the lines posted to this list earlier 
>by Patrick. This only affects the cards that use the 
>Microtune 4042 tuner. This is not ideal, but there is no 
>current specification for selecting RF inputs. It makes the 
>card work the same way as the Windows driver thus it may 
>reduce user confusion.
>
> This patch is against the 2005-07-14 version of the
>
>video4linux CVS. That version still has the lgdt3302.* files 
>and the makefile to build them. 
>
>I will post patches for items 3 - 6 as I complete them.
>  
>
I have tested both of your patches 1 & 2, and they do not break my 
hardware.  Since they were successfully in producing the desired results 
with your tuner, I have split up the patches and committed them to the 
video4linux and dvb-kernel trees.  I have noted in the commit messages 
and v4l changelog that this series of patches spans both trees.

I have noticed from lsmod, that dvb-pll is no longer a dependency of 
lgdt3302 (just like mt352 has always been)... Was this intended?
What a shame that dvb-pll still has to load anyway along with or51132, 
cx22702 and mt352. :'(

There is one minor problem that needs to be addressed...

  CC [M]  /home/mkrufky/video4linux/lgdt3302.o
/home/mkrufky/video4linux/lgdt3302.c:103: warning: `i2c_readbytes' 
defined but not used

I am about to apply the following patch to cvs to suppress this 
warning.  Tell me if this code should be removed altogether, or if you 
plan to use it again in the future:


-------------- next part --------------
Suppress the following during compile:
warning: `i2c_readbytes' defined but not used

Signed-off-by: Michael Krufky <mkrufky at m1k.net>

 lgdt3302.c |    2 ++
 1 files changed, 2 insertions(+)

diff -upr a/lgdt3302.c b/lgdt3302.c
--- a/lgdt3302.c	2005-07-20 02:09:19.000000000 +0000
+++ b/lgdt3302.c	2005-07-20 02:10:10.000000000 +0000
@@ -96,6 +96,7 @@ static int i2c_writebytes (struct lgdt33
 	return 0;
 }
 
+#if 0
 static int i2c_readbytes (struct lgdt3302_state* state,
 			  u8 addr, /* demod_address or pll_address */
 			  u8 *buf, /* holds data bytes read */
@@ -111,6 +112,7 @@ static int i2c_readbytes (struct lgdt330
 	}
 	return 0;
 }
+#endif
 
 /*
  * This routine writes the register (reg) to the demod bus


More information about the linux-dvb mailing list