[linux-dvb] voltage control for DVB-T and DiSEqC switches

[Johannes Stezenbach]

Kenneth Aafløy wrote:
> lørdag 23. juli 2005, 22:59, skrev Kenneth Aafløy:
> > lørdag 23. juli 2005, 09:45, skrev Dominik Strasser:
> > >  typedef enum fe_sec_voltage {
> > > - SEC_VOLTAGE_13,
> > > - SEC_VOLTAGE_18,
> > > - SEC_VOLTAGE_OFF
> > > + SEC_VOLTAGE_13 = 0,  /* 13V DVB-S vertical */
> > > + SEC_VOLTAGE_18 = 1,  /* 18V DVB-S horizontal */
> > > + SEC_VOLTAGE_OFF = 2, /*  0V DVB-S / -T standby / passive antenna */
> > > + SEC_VOLTAGE_5 = 3,  /*  5V DVB-T active antenna */
> > > + SEC_VOLTAGE_12 = 4  /* 12V DVB-S DiSEqC */
> > > + VOLTAGE_13 = 0,  /* 13V DVB-S vertical */
> > > + VOLTAGE_18 = 1,  /* 18V DVB-S horizontal */
> > > + VOLTAGE_OFF = 2, /*  0V DVB-S / -T standby / passive antenna */
> > > + VOLTAGE_5 = 3,  /*  5V DVB-T active antenna */
> > > + VOLTAGE_12 = 4  /* 12V DVB-S DiSEqC */
> > >  } fe_sec_voltage_t;
> > > + 
> > > +  typedef fe_sec_voltage_t fr_voltage_t;
> > 
> > I love this, except for the namespace issues, make it be prefixed
> > by FE_/DVB_ instead.

I think I like the original version better, because it makes
the minimal change and keeps confusion at a minimum.

Johannes