[linux-dvb] [PATCH] NXT200X - Change lengths from u8 to int

Philip Prindeville philipp_subx at redfish-solutions.com
Sat Nov 5 20:37:50 CET 2005


Michael Krufky wrote:

> Philip Prindeville wrote:
>
>> Kirk Lapray wrote:
>>
>>> This patch changes all lengths from u8 to int types.  It seems to 
>>> make more sense that we use int instead of u8.  I am not sure why I 
>>> didn't do that in the first place.
>>
>>
>> Ok, so how do you handle a (len < 0) condition now that you've created
>> that possibility where it didn't exist before?
>>
>> -Philip
>
>
> Kirk-
>
> I reverted the patch...  Thanks again. :-)
>
> Philip-
>
> WHAT are you talking about?


Changing a parameter from unsigned to signed creates the possibility
of a new out-of-bounds condition.


>
> You need to look at the code before you criticise.


It wasn't a criticism, it was an observation.

-Philip

>
> -MiKE





More information about the linux-dvb mailing list