[linux-dvb] [PATCH] NXT200X - Change lengths from u8 to int

Johannes Stezenbach js at linuxtv.org
Sun Nov 6 08:34:43 CET 2005


On Fri, Nov 04, 2005 at 03:01:25PM -0700, Kirk Lapray wrote:
> After looking everything over there should never be a time when we need to
> set a length longer than 255. Therefore, unless anyone has any other ideas,
> we should just revert this patch and use the u8 type for all lengths (or at
> least for the one in nxt200x_writebytes). It seemed like it would make more
> sense to use int, but it is really not necessary, and it is a security
> concern.

I think it would be best to check the callers of nxt200x_writebytes
for the maximum required size for the array, and then convert the
variable sized array into a fixed sized array, and add a check
to ensure that len does not exceed the size of the array.

Johannes



More information about the linux-dvb mailing list