[linux-dvb] Re: [PATCH] support for KWorld DVB-S 100 updated

Vadim Catana vcatana at registru.md
Tue Nov 22 16:14:42 CET 2005


Johannes Stezenbach wrote:
> Patch looks good to me except two very minor nits which we can
> fix ourselves before commit:
> 
>>+	switch (state->config->use_isl6421) {
> 
> ...
> 
>>+	case 1:
> 
> ...
> 
>>+	case 0:
> 
> 
> odd; why not if () ... else ... ?

There could be more than 2 ways to implement LNB control via CX24123.
For example, the KWorld DVB-S 100 card uses the default values for
LNBDCPol and LNBDCODEn, but some other manufacturers may use a
diferent design. I thought there could be case 2: ... , case 3 ... :,
etc.

But if you think if() ... else ... is better, please fix it,
I have no objections.

 From CX24123 Software Description:

LNBDCPol LNB_DC Pin Polarity. (Default: 0)
	0 = Normal LNB_DC pin polarity.
	1 = Inverted LNB_DC pin polarity.

LNBDCODEn LNB_DC Pin Open Drain Enable. (Default: 0)
	The state of this register bit controls the configuration of the
	LNB_DC pin.
	0 = Open drain (requires external pull-up).
	1 = CMOS output

Regards,
Vadim Catana




More information about the linux-dvb mailing list