[linux-dvb] [PATCH] support for KWorld DVB-S 100 updated

Vadim Catana vcatana at registru.md
Wed Nov 23 12:32:57 CET 2005


Michael Krufky wrote:
> Vadim AND Steve-
> 
> Please test the current merged v4l+dvb cvs trees and confirm proper 
> functionality of this implementation.
> 
> 
> I've applied your patches to v4l-kernel and dvb-kernel cvs, with some 
> small changes (inline) :
> 
>> diff -urN ./v4l-kernel.cvs/linux/drivers/media/video/cx88/cx88-dvb.c 
>> ./v4l-kernel/linux/drivers/media/video/cx88/cx88-dvb.c
>> --- ./v4l-kernel.cvs/linux/drivers/media/video/cx88/cx88-dvb.c    
>> 2005-11-13 20:11:21.000000000 +0200
>> +++ ./v4l-kernel/linux/drivers/media/video/cx88/cx88-dvb.c    
>> 2005-11-22 11:37:32.000000000 +0200
>> @@ -332,10 +332,29 @@
>>      return 0;
>>  }
>>  
>> +static void cx24123_enable_lnb_voltage(struct dvb_frontend* fe, int on)
> 
> 
> I renamed this from enable_lnb_voltage...

actually, the lnb voltage is enabled/disabled by cx23883 via its GPIO
pins and insead of cx24123 there could be any other demodulator.
Maybe a better name would be cx88_enable_lnb_voltage ?

>> diff -urN ./v4l-kernel.cvs/linux/drivers/media/video/cx88/cx88-i2c.c 
>> ./v4l-kernel/linux/drivers/media/video/cx88/cx88-i2c.c
>> --- ./v4l-kernel.cvs/linux/drivers/media/video/cx88/cx88-i2c.c    
>> 2005-10-16 15:13:58.000000000 +0300
>> +++ ./v4l-kernel/linux/drivers/media/video/cx88/cx88-i2c.c    
>> 2005-11-20 20:38:23.000000000 +0200
>> @@ -175,6 +175,7 @@
>>      [ 0xa0 >> 1 ] = "eeprom",
>>      [ 0xc0 >> 1 ] = "tuner (analog)",
>>      [ 0xc2 >> 1 ] = "tuner (analog/dvb)",
>> +    [ 0x2a >> 1 ] = "tuner (cx24123)",
>>  };
>>  
>>  static void do_i2c_scan(char *name, struct i2c_client *c)
> 
> 
> I dropped this entirely -- You yourself have proven that cx24123 can be 
> found at multiple i2c addresses ...

Maybe both addresses can be added and do_i2c_scan would report that
it found a tuner, instead of "???".

Anyway, I tested the current dvb+v4l cvs trees and its working fine.

Thanks,
Vadim Catana







More information about the linux-dvb mailing list