[linux-dvb] [Patch] FMD1216 band updates and control bytes

[Hartmut Hackmann]

Hi, Steve

Steve Toth wrote:
> I went through the FMD1216 datasheet and updated the FMD PLL bands based 
> on the official document. The current values differ from the datasheet.
> 
> The existing dvb-pll.c values appear to work fine for the HVR1100, and 
> also work fine for many of the existing FMD tuner products so I don't 
> know whether this patch will be accepted or not. Some of the existing 
> bands are out (just a little) so tuning problems with the current values 
> may not be completely obvious. The current values are close, but not 
> accurate.
> 
> I submit this for comment/review.
> 
> If we feel the patch is appropriate I'll re-submit with sign-off.
> 
> Any testers who would like to try this out, I'd appreciate the feedback.
> 
> Regards,
> 
> Steve Toth
> 

Hm, the data sheet of the FMD2116ME MK3 is - lets say - a problem.
One issue is the DVB-T IF frequency. I got told it is 36.125MHz but
this can't be right. The tuner can't tune to this frequency, it should
be 36.167MHz. Tuning step size definitely is 166.667kHz (4MHz / 24),
so this is wrong in your patch. Also all examples in the data sheet
have bit 6 of the bandswitch byte set...

There generally is a problem with dvb-pll.c: I miss functions to
initialize and to "deinitialize" the tuner. This is very important for
hybrid analog and digital cards. That's why i have my own versions in
saa7134-dvb.c - including FMD1216. This should be changed some time.

Best regards
   Hartmut

> 
> ------------------------------------------------------------------------
> 
> Index: linux/drivers/media/dvb/frontends/dvb-pll.c
> ===================================================================
> RCS file: /cvs/video4linux/v4l-dvb/linux/drivers/media/dvb/frontends/dvb-pll.c,v
> retrieving revision 1.13
> diff -u -p -r1.13 dvb-pll.c
> --- linux/drivers/media/dvb/frontends/dvb-pll.c	27 Oct 2005 04:11:59 -0000	1.13
> +++ linux/drivers/media/dvb/frontends/dvb-pll.c	28 Nov 2005 22:26:55 -0000
> @@ -252,18 +252,18 @@ static void fmd1216me_bw(u8 *buf, u32 fr
>  
>  struct dvb_pll_desc dvb_pll_fmd1216me = {
>  	.name = "Philips FMD1216ME",
> -	.min = 50870000,
> -	.max = 858000000,
> +	.min = 48000000,
> +	.max = 862000000,
>  	.setbw = fmd1216me_bw,
>  	.count = 7,
>  	.entries = {
> -		{ 143870000, 36213333, 166667, 0xbc, 0x41 },
> -		{ 158870000, 36213333, 166667, 0xf4, 0x41 },
> -		{ 329870000, 36213333, 166667, 0xbc, 0x42 },
> -		{ 441870000, 36213333, 166667, 0xf4, 0x42 },
> -		{ 625870000, 36213333, 166667, 0xbc, 0x44 },
> -		{ 803870000, 36213333, 166667, 0xf4, 0x44 },
> -		{ 999999999, 36213333, 166667, 0xfc, 0x44 },
> +		{ 141999999, 36130000, 166700, 0xbc, 0x01 },
> +		{ 161999999, 36130000, 166700, 0xf4, 0x01 },
> +		{ 381999999, 36130000, 166700, 0xb4, 0x02 },
> +		{ 437999999, 36130000, 166700, 0xfc, 0x02 },
> +		{ 637999999, 36130000, 166700, 0xbc, 0x04 },
> +		{ 845999999, 36130000, 166700, 0xf4, 0x04 },
> +		{ 862000000, 36130000, 166700, 0xfc, 0x04 },
>  	}
>  };
>  EXPORT_SYMBOL(dvb_pll_fmd1216me);
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> linux-dvb mailing list
> linux-dvb at linuxtv.org
> http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb