[linux-dvb] [PATCH] HD5000 Support

[Michael Krufky]

Taylor Jacob wrote:
> Here is the "cleaned up" patch for adding support for the Air2PC/Airstar2 HD5000
> (LGDT3303 Frontend).
> 
> http://www.digitalregime.com/patches/hd5000-cleanup.patch

Mac Michaels wrote:
> I suggest a few changes to this patch. I inserted it a a 
> quote so that I can work my comments into it.
> 
>>diff -u -r1.10 lgdt330x.c
>>--- linux/drivers/media/dvb/frontends/lgdt330x.c	10 Sep 2005 08:12:36 -0000	1.10
>>+++ linux/drivers/media/dvb/frontends/lgdt330x.c	25 Sep 2005 16:52:09 -0000
>>@@ -218,7 +219,8 @@
>> 	};
>> 
>> 	static u8 lgdt3303_init_data[] = {
>>-		0x4c, 0x14
>>+		0x4c, 0x14,
>>+		0x87, 0xF3
> 
> This may be a problem. This change flips the polarity of the 
> clock for the mpeg data transfer clock. The best I can tell 
> the CX2388x requires the default high clock. This change 
> flips that and may cause problems. It should be 
> conditionalized. 
> 

Taylor,

I have applied your patch to cvs, but with some changes.  I have 
conditionalized the lgdt3303_init_data change quoted above, leaving it 
disabled by default.  (the cx88 and bttv implementations require this) 
The HD5000 enables it in the flexcop driver by setting 
clock_polarity_flip.  (I named that based on Mac's comments above.  If 
anyone has a better name suggestion, please propose one. )

I have left the SNR changes off for now.  Please resubmit a new patch 
after reviewing Mac's earlier comments in this thread.  (mac did not cc 
them to you, but they are on the linux-dvb list)

Thank you.
-- 
Michael Krufky