[linux-dvb] Kernel locking in dst [Corrected PATCH]

Manu Abraham abraham.manu at gmail.com
Tue Oct 18 20:04:13 CEST 2005


Henrik Sjoberg wrote:

>>>>			state->decode_snr = state->rxbuffer[2] << 8 | state->rxbuffer[3];
>>>>		} else if ((state->dst_type == DST_TYPE_IS_TERR) || (state->dst_type
>>>>== DST_TYPE_IS_CABLE)) {
>>>>			state->decode_lock = (state->rxbuffer[1]) ? 1 : 0;
>>>>-			state->decode_strength = state->rxbuffer[4] << 8;
>>>>			state->decode_snr = state->rxbuffer[3] << 8;
>>>>+			if (state->dst_hw_cap & DST_TYPE_HAS_CA) {
>>>>+				state->decode_strength = state->rxbuffer[5] << 8;
>>>>+			} else {
>>>>+				state->decode_strength = state->rxbuffer[4] << 8;
>>>>+			}
>>>>
>>>>
>>>>        
>>>>
>>What's this one for ? It surely doesn't belong to the lock issue.. If
>>you need it for some reason, please do send it as a different patch.
>>
>>Manu
>>
>>    
>>
>
>Ah, you're correct. This is another problem I'm seeing. The signal
>strength is at pos 5 and not 4 on my card (VP-3040). The reason why I
>haven't sent it  in as a patch is that I don't know the critera for when
>the signal strength is at pos 5. Right now I'm using CA module as
>criteria.
>  
>

Send it in as another patch.  You are sending in the fix for the 
dst_get_tuna() too , i presume so.
please do a Sign off also on that. I will check it in to CVS at the 
earliest.

Regarding the signal strength patch, if you need it please do send it in 
as a different patch. I will check in all of the driver patches straight 
away.

Regards,
Manu




More information about the linux-dvb mailing list