[linux-dvb] stv099 enhanced tuning code gone

Johannes Stezenbach js at linuxtv.org
Mon Oct 24 00:39:05 CEST 2005


On Sat, Oct 22, 2005 Oliver Endriss wrote:
> Oliver Endriss wrote:
> > Andrew de Quincey wrote:
> > > As the subject says - lemme know this causes any problems...
> > 
> > I don't know if this causes any problems:
> > For philips_su1278 the old code set register 0x12 to 0xda in the
> > budget-ci driver. Now register 0x12 is overwritten with 0xb9.
> > 
> > What about these additional modifications:
> > 
> > Index: stv0299.c
> > ===================================================================
> > RCS file: /cvs/linuxtv/dvb-kernel/linux/drivers/media/dvb/frontends/stv0299.c,v
> > retrieving revision 1.72
> > diff -p -u -r1.72 stv0299.c
> > --- stv0299.c   3 Oct 2005 14:20:43 -0000       1.72
> > +++ stv0299.c   6 Oct 2005 14:32:46 -0000
> > @@ -560,8 +560,6 @@ static int stv0299_set_frontend(struct d
> >         stv0299_set_symbolrate (fe, p->u.qpsk.symbol_rate);
> >         stv0299_writeregI(state, 0x22, 0x00);
> >         stv0299_writeregI(state, 0x23, 0x00);
> > -       stv0299_readreg (state, 0x23);
> > -       stv0299_writeregI(state, 0x12, 0xb9);
> > 
> >         state->tuner_frequency = p->frequency;
> >         state->fec_inner = p->u.qpsk.fec_inner;
> > 
> > Imho the deleted lines are not required (tested with BSRU6).
> > Register 0x12 should be set using xxx_inittab.
> > (inittabs for BSRU6/BSBE1 need to be adjusted: 0xb5 -> 0xb9,
> > for philips_su1278 0xda is used.)
> > 
> > Any comments?
> 
> Ok, last chance: ;-)
> If nobody objects I will apply the patch above and adjust inittabs for
> BSRU6 and BSBE1 accordingly.

Please just do it.

Johannes



More information about the linux-dvb mailing list