[linux-dvb] I2C changes in 2.6.14-rc1 causes breakage

C.Y.M syphir at syphir.sytes.net
Tue Sep 20 03:43:34 CEST 2005


Michael Krufky wrote:
> C.Y.M wrote:
> 
>> C.Y.M wrote:
>>
>>>> - This patch is incomplete. Full patches were created by
>>>> Jean Delvare <khali at linux-fr.org> and posted to lkml:
>>>
>>>
>>>
>>> Ok, here is a full patch for the changes to "DVB" cards and
>>> 2.6.14-rc1 kernel.
>>> BTW, my Nexus card seems to be working really well with latest changes.
>>>
>>
>>
>> Oops, forgot one line in the flexcop driver.  Here is a fixed patch.
>>
>> Regards,
> 
> 
> I think you forgot another line:
> 
>>
>>
>> ------------------------------------------------------------------------
>>
>> --- dvb-kernel/linux/drivers/media/common/saa7146_i2c.c.orig   
>> 2005-09-01 13:22:29.000000000 -0700
>> +++ dvb-kernel/linux/drivers/media/common/saa7146_i2c.c    2005-09-14
>> 23:59:53.000000000 -0700
>> @@ -386,8 +386,6 @@
>>  
>>  /* exported algorithm data */
>>  static struct i2c_algorithm saa7146_algo = {
>> -    .name        = "saa7146 i2c algorithm",
>> -    .id        = I2C_ALGO_SAA7146,
> 
> 
> here, i would assume there should be something like:
> 
>   +    .id        = I2C_HW_SAA7146,
> 

Its there, in the second hunk. :)  But some backwards compat would be nice to add.

Regards,



More information about the linux-dvb mailing list