[linux-dvb] [PATCH] cx88, too noisy

Trent Piepho xyzzy at speakeasy.org
Thu Apr 6 21:36:40 CEST 2006


Changeset 395c7c4d8f0c changed several dprintks from level 1 to level 0
(always on).  They generate four lines every time DMA starts, which don't
containing any information with a use outside of debugging.  You get a lot of
messages in the kernel log during normal operation:

Apr  3 13:43:42 t2 kernel: cx88[0]/2: queue is empty - first active
Apr  3 13:43:42 t2 kernel: cx88[0]/2: cx8802_start_dma w: 0, h: 0, f: 2
Apr  3 13:43:42 t2 kernel: cx88[0]/2: setting the interrupt mask
Apr  3 13:43:42 t2 kernel: cx88[0]/2: [d3a73160/0] cx8802_buf_queue - first active
Apr  3 13:44:37 t2 kernel: cx88[0]/2: queue is empty - first active
Apr  3 13:44:37 t2 kernel: cx88[0]/2: cx8802_start_dma w: 0, h: 0, f: 2
Apr  3 13:44:37 t2 kernel: cx88[0]/2: setting the interrupt mask
Apr  3 13:44:37 t2 kernel: cx88[0]/2: [c4723100/0] cx8802_buf_queue - first active

and so on.  This patch just changes these dprintks back to level 1.
-------------- next part --------------
# HG changeset patch
# User Trent Piepho <xyzzy at speakeasy.org>
# Node ID e7d1a5c44be5d47166720d0be465327af0a28b02
# Parent  c42c55c1095ae910401c73147c4dbf3f0e3a5551
Silence some dprintk's in cx88-mpeg

From: Trent Piepho <xyzzy at speakeasy.org>

Changeset 395c7c4d8f0c changed several dprintks from level 1 to level 0
(always on).  They generate four lines every time DMA starts, which don't
containing any information with a use outside of debugging.  This turns them
back to level 1.

Signed-off-by: Trent Piepho <xyzzy at speakeasy.org>

diff -r c42c55c1095a -r e7d1a5c44be5 linux/drivers/media/video/cx88/cx88-mpeg.c
--- a/linux/drivers/media/video/cx88/cx88-mpeg.c	Wed Apr  5 18:48:44 2006 -0700
+++ b/linux/drivers/media/video/cx88/cx88-mpeg.c	Thu Apr  6 12:00:41 2006 -0700
@@ -62,7 +62,7 @@ static int cx8802_start_dma(struct cx880
 {
 	struct cx88_core *core = dev->core;
 
-	dprintk(0, "cx8802_start_dma w: %d, h: %d, f: %d\n", dev->width, dev->height, buf->vb.field);
+	dprintk(1, "cx8802_start_dma w: %d, h: %d, f: %d\n", dev->width, dev->height, buf->vb.field);
 
 	/* setup fifo + format */
 	cx88_sram_channel_setup(core, &cx88_sram_channels[SRAM_CH28],
@@ -126,7 +126,7 @@ static int cx8802_start_dma(struct cx880
 	q->count = 1;
 
 	/* enable irqs */
-	dprintk( 0, "setting the interrupt mask\n" );
+	dprintk( 1, "setting the interrupt mask\n" );
 	cx_set(MO_PCI_INTMSK, core->pci_irqmask | 0x04);
 	cx_set(MO_TS_INTMSK,  0x1f0011);
 #if 0
@@ -142,7 +142,7 @@ static int cx8802_stop_dma(struct cx8802
 static int cx8802_stop_dma(struct cx8802_dev *dev)
 {
 	struct cx88_core *core = dev->core;
-	dprintk( 0, "cx8802_stop_dma\n" );
+	dprintk( 1, "cx8802_stop_dma\n" );
 
 	/* stop dma */
 	cx_clear(MO_TS_DMACNTRL, 0x11);
@@ -257,13 +257,13 @@ void cx8802_buf_queue(struct cx8802_dev 
 	buf->risc.jmp[1] = cpu_to_le32(cx88q->stopper.dma);
 
 	if (list_empty(&cx88q->active)) {
-		dprintk( 0, "queue is empty - first active\n" );
+		dprintk( 1, "queue is empty - first active\n" );
 		list_add_tail(&buf->vb.queue,&cx88q->active);
 		cx8802_start_dma(dev, cx88q, buf);
 		buf->vb.state = STATE_ACTIVE;
 		buf->count    = cx88q->count++;
 		mod_timer(&cx88q->timeout, jiffies+BUFFER_TIMEOUT);
-		dprintk(0,"[%p/%d] %s - first active\n",
+		dprintk(1,"[%p/%d] %s - first active\n",
 			buf, buf->vb.i, __FUNCTION__);
 #if 0
 		udelay(100);
@@ -303,7 +303,7 @@ static void do_cancel_buffers(struct cx8
 	}
 	if (restart)
 	{
-		dprintk(0, "restarting queue\n" );
+		dprintk(1, "restarting queue\n" );
 		cx8802_restart_queue(dev,q);
 	}
 	spin_unlock_irqrestore(&dev->slock,flags);


More information about the linux-dvb mailing list