[linux-dvb] [PATCH] Make v4l-dvb compile under kernels < 2.6.16

Michael Krufky mkrufky at linuxtv.org
Sun Apr 9 17:08:00 CEST 2006


Trent Piepho wrote:
> The new drivers added to Hg don't all compile with kernels older than 2.6.16,
> mostly do to the mutex.h stuff.  This patch will get them all to compile
> cleanly.  Of course I don't have the hardware to test that all the drivers
> actually WORK with older kernels, but they will compile.  Nothing should
> change for kernels >= 2.6.16.
> 
> BTW, this patch would have been about half the work if compat.h would just:
> #define mutex semaphore
> for pre-mutex kernels.  As long as no one tries to export a variable or
> function named mutex, and no one does, it's not going to mess anything up.


Trent-

I think that you're correct.  To make these changes in compat.h would be 
much less invasibe and definately would be the preferred method of doing 
things.

We try to keep as much of the compatability hacks in compat.h as 
possible, mainly for the sake of cleanliness and code readability.

Thanks for this patch, but in light of a better method, I'd rather not 
apply this.  Please try out the method using compat.h as you've 
described above.  The current drivers already containing the semaphore 
to mutex compat-hack could be altered as well.

If it all works as planned, I'd rather use the cleaner, compat.h method.

-Mike



More information about the linux-dvb mailing list