[linux-dvb] [PATCH] Make v4l-dvb compile under kernels < 2.6.16

Trent Piepho xyzzy at speakeasy.org
Mon Apr 10 03:50:44 CEST 2006


On Sun, 9 Apr 2006, Mauro Carvalho Chehab wrote:
> Em Dom, 2006-04-09 =E0s 16:51 -0700, Trent Piepho escreveu:
> > Michael suggested that I try add the define to rename the struct in com=
pat.h,
> > as this will remove a lot of compat code from all the drivers.  What do=
 you
> > say?  All that #if stuff can build up to make quite a mess.
> Hmmm... #define mutex semaphore seems to be too dangerous, since it
> might change some non-struct names and might generate some naming
> conflicts. It would be nice if there were some way to change "struct
> mutex" into "struct semaphore", but I dunno any ways of doing this with
> gpp.

I can make the change so that everything works and there are no conficts wi=
th
non-struct names.  It will remove a lot of #if stuff.  There will be no
problems or potential problems with the existing code.

The only problem would be if someone later tried to create an identifier na=
med
just 'mutex', and also created one named 'semaphore' which shared scope wit=
h
the 'mutex' one.  Then they'd have to compile that on a pre-mutex kernel.  =
Not
that dangerous I think.



More information about the linux-dvb mailing list