[linux-dvb] [PATCH] Moving ALPS BSRV2 tuner handling code to separate file.

Michael Krufky mkrufky at linuxtv.org
Fri Apr 14 18:53:18 CEST 2006


Perceval Anichini wrote:
> Hello all !
>
> Continueing to move the frontends code from ttpci/ tp
> frontends.
>
> This patch : 
>   - Moves the ALPS BSRV2 tuner code to frontends/bsrv2.h
>   - Adapts accordingly ves1x93.{c,h} so that the pll_set ()
>     function accepts the i2c_adapter as an argument. (Copying
>     stv0299 behavior...)
>   - Modify accordingly av7110.c, budget-patch.c, budget.c
>
> Could someone please try this patch ? It compiles properly,
> but I don't have any way to test it, as I don't have a card
> like that...
Perceval-

I think that this was a good idea, although the same exact thing could 
be done for all of the other drivers, potentially leading to the 
creation of many many more modules just for handling pll's ...

I would much rather see the pll definition moved into dvb-pll, and the 
pll_set function altered to use dvb_pll_configure.  That still leaves us 
with duplicated ves1x93_config structs, but I think that this would be 
the lesser of the evils...


Regards,

Michael Krufky





More information about the linux-dvb mailing list