[linux-dvb] [PATCH] Moving ALPS BSRV2 tuner handling code to separate file.

Andreas Oberritter obi at linuxtv.org
Sat Apr 15 09:12:50 CEST 2006


Michael Krufky wrote:
> Andreas Oberritter wrote:
> 
>> Michael Krufky wrote:
>>  
>>> I would much rather see the pll definition moved into dvb-pll, and the
>>> pll_set function altered to use dvb_pll_configure.
>>>   
>> The code can still be changed to use dvb-pll afterwards without
>> unnecessary code duplication.
>>  
>>
> I can agree to that.  The same can be done for lg-h06xf, and many
> others.  A lot of duplicated code could be removed, and I do agree that
> this would be a step forward.  The only problem I see with this is that
> we'll end up with many tiny little header files just like this one,
> bsbe1.h and bsru6.h  ...  This isn't necessarily a bad thing either.  I
> just didn't know if this is what we wanted to be doing.  Would it make
> sense to consolidate these small files into single source.[ch] files? 

I like small independent files.

Btw. such a change has been proposed by me last summer and Johannes
suggested using a common prefix like "fe-" although I'd vote for using
"nim_".

http://thread.gmane.org/gmane.linux.drivers.dvb/19261/focus=19261

My old patch is still available but moved to a new URL.
http://www.saftware.de/patches/frontend.diff

Regards,
Andreas

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: OpenPGP digital signature
Url : http://www.linuxtv.org/pipermail/linux-dvb/attachments/20060415/fc461387/signature.pgp


More information about the linux-dvb mailing list