[linux-dvb] [PATCH] Multi protocol support

[Manu Abraham]

Andreas Oberritter wrote:
> Hi Manu,
>
> Manu Abraham wrote:
>   
>> +typedef enum {
>> +       DMX_PROTO_DVB_S,
>> +       DMX_PROTO_DVB_C,
>> +       DMX_PROTO_DVB_T,
>> +       DMX_PROTO_DSS,
>> +       DMX_PROTO_ATSC,
>> +       DMX_PROTO_DVB_S2
>> +} dmx_protocol_t;
>>     
>
> Why should a demux care how the TS was delivered? All DVB variants and
> ATSC use MPEG-2 TS, right? I don't know about DSS though.
>
>   
>> +typedef enum {
>> +       DMX_TRANSPORT,
>> +       DMX_GENERIC_PACKET,
>> +       DMX_GENERIC_CONTINUOUS,
>> +       DMX_RESERVED
>> +} dmx_bbheader_t;
>>     
>
> What is this data type good for? It seems to be unused.
>
>   
>> +typedef enum {
>> +       FE_PROTO_DVB_S,
>> +       FE_PROTO_DVB_C,
>> +       FE_PROTO_DVB_T,
>> +       FE_PROTO_DSS,
>> +       FE_PROTO_ATSC,
>> +       FE_PROTO_DVB_S2
>> +} fe_protocol_t;
>>     
>
> I don't think that protocol is a proper name. In DVB terms S, C and T
> are called delivery systems.
>
>   
>> +typedef enum {
>> +       FE_TRANSPORT,
>> +       FE_GENERIC_PACKET,
>> +       FE_GENERIC_CONTINUOUS,
>> +       FE_RESERVED
>> +} fe_bbheader_t;
>>     
>
> See dmx_bbheader_t.
>
> IIRC it was discouraged to introduce new typedefs.
>   

The idea of discouraging typedef's was for typedefining a struct IIRC