[linux-dvb] Re: Moving tuner handling code to separate file.

Andreas Oberritter obi at linuxtv.org
Sun Apr 16 23:11:21 CEST 2006


Michael Krufky wrote:
> You are mistaken.  The LG TDVS H-06xF is a NIM.

Oops, sorry. Your code made it look like it wasn't one.

You can move the config struct there, too. Just create a function called 
lg_tvds_h06xf_attach(struct i2c_adapter *i2c, u8 addr, int serial, int 
polarity) for example. This hides the struct from the caller, who then 
knows that he doesn't need lookup and change the other variables of the 
struct for this module.

You can also remove the pll_set wrappers you have in the three drivers 
by changing the pll_set function to take a "struct i2c_adapter *".

Regards,
Andreas



More information about the linux-dvb mailing list