[linux-dvb] [PATCH]Frontends or51132, or51211 move common code to module

[Gunther Mayer]

Manu Abraham wrote:

> Andrew de Quincey wrote:
>
>> On Friday 14 April 2006 05:19, Rusty Scott wrote:
>>  
>>
>>> The attached patch moves the common logarithm code found in the 
>>> or51211 and
>>> or 51132 frontends into a module that can be accessed by other 
>>> frontends as
>>> well. This patch is in anticipation of using the logarithm code in the
>>> lgdt330x module to calculate a signal strength which is currently 
>>> not done.
>>>     
>>
>>
>> What about making it an "arithmetic module" instead of just for logs? 
>> From what I see we're going to be needing a place to put more and 
>> more things like this.. e.g. a fixed point implementation might be 
>> handy at some point as well (not that I'm suggesting you write that! 
>> Just renaming the module).
>>   
>
>
> Yeah, would be nice. The last we discussed, Ralph suggested that we 
> can probably add it to dvb-core, rather than a separate module, while 
> being at the new modules.
>
I agree: do not add to module inflation. There are too much modules already.