[linux-dvb] [PATCH]Frontends or51132, or51211 move common code to module

Rusty Scott rustys at ieee.org
Wed Apr 19 02:28:52 CEST 2006


On Wed, 2006-04-19 at 02:58 +0400, Manu Abraham wrote:
> Andrew de Quincey wrote:
> > On Tuesday 18 April 2006 23:21, Rusty Scott wrote:
> >   
> >> So can someone give me a quick decision on what I should do? Should I
> >> put that code into dvb-core.c or make a new dvb_core_math.c?
> >>     
> >
> > I would say put it in dvb_core_math.c, but link it into the dvb-core.ko 
> > module.
> >
> >   
> 
> 
> what about dvb_math.c ? But we will need a log function which has a 
> better precision for tuning algorithm. Christoph Pfister volunteered to 
> do one for the stb0899. If we have a common one which is quite precise 
> would be nice.
> 
> He sent me a preview, i think it needed a bit more tuning up, he said he 
> got an accuracy of 0.054%
> 
WTF?  I'm asking what I should do with my patch so I can get this code
fixed, placed in a common place, and use it in another module.  If
someone wants to then patch that with a more accurate ilog2 and write a
conversion to i10log10 or whatever I'm fine with that too.

When I'm asking the question what should I do, I'm not really looking
for the response "this is what someone else is doing that might be
tangentially related to what you have submitted."  Give me some
direction here.

dvb_math or dvb_core_math?  linked into dvb_core.ko?

Thanks,

Rusty







More information about the linux-dvb mailing list