[linux-dvb] [PATCH] TT Budget 1500 S

[Oliver Endriss]

Perceval Anichini wrote:
> Attached 2 patches :
> 
>   ttpci-lnbp21-set-voltage-fixed-masks sets more precisely the
> masks for the function lnbp21_set_voltage () function. This is
> an almost cosmetic patch.

Bit 2 is set anyway, bits 0 and 1 are read-only.
Your patch would not change anything...

I suggest to delay that until the LNBP21 code is factored out into a
separate file. Currently there are at least 3 lnbp21 implementations
in the driver tree.

>   ttpci-tt-budget-1500s-fix fixed a S1500 issue : When set in
> vertical mode, the card loose the signal sync. The fix is to
> set the card in "high voltage mode". This has been confirmed
> from TechnoTrend. (Many thanks for their help)

Nak. You must not enable high voltage by default.

Maybe it would be useful to add a module parameter 'high_lnb_voltage'
to dvb_frontend.c. This way cable length compensation could be enabled
if the application software does not support the ioctl.

Oliver

-- 
--------------------------------------------------------
VDR Remote Plugin available at
http://www.escape-edv.de/endriss/vdr/
--------------------------------------------------------