[linux-dvb] [PATCH] TT Budget 1500 S

[Oliver Endriss]

Perceval Anichini wrote:
> > Unfortunately, I'm not sure whether some LNB hardware might be damaged
> > if LLC is enabled for the wrong card. That's why I am very careful. ;-)
> 	I understand that :)
> 
> > Hm - sounds like a hardware problem. Apparently the tuner needs a higher
> > voltage from the LNBP21 chip...
> 	Yep! Sounds the same to me !
> 
> > The Technotrend/Nexus rev 2.3 cards use the same BSBE1/LNBP21 setup.
> > There were no problem reports although it is widely used with vdr.
> > Strange.
> 	If this is a hardware problem of the 1500S, this is normal :)
> 
> > My sleep would be better if you could check that. ;-)
> > Anyway, if TT recommends that fix it should be safe.
> 	Ok.
> 	
> > Oops. ;-)
> > 
> > Please test whether it works if you place something like
> > |	if (budget->dev->pci->subsystem_device == 0x1017)
> > |		lnbp21_enable_high_lnb_voltage(budget->dvb_frontend, 1)
> > after dvb_register_frontend().
> 	Yes, it is working like a charm. But don't you find
> it is a rather bad idea to write a structure like :
> 	switch (a)
> 	{
> 		case 0 :
> 		[...]
> 	}
> 
> 	[...]
> 	if (a == 0)
> 		[...]
> 
> I do understand that small patches are a good (and necessary !!!) thing
> so that it is easier to figure out that what's done is what it shall
> be... But in our case, I find this rather breaks the code structure :/
> That's why I prefered to handle the problem the way I did in my
> patches...

It was only meant to be a quick and dirty test.

Because I don't like to have another copy of the LNBP21 code in the
tree, I'm working on a patch which moves LNBP21 and BSBE1 stuff to
separate files. Doing that requires some other changes as well.
I'll post it to the list for discussion asap.

> Moreover, the budget.c and budget_ci.c structure is not the same. (And
> the same modification in budget_ci is even uglier !!!!), so maybe it
> would be a better idea to move first the code handling the card from
> budget.c to budget-ci.c, and then modify the LNB stuff ???????

Sooner or later, the 3 budget drivers should be merged into one driver.
Requires a lot of work: CI/IR/AV code must be factored out, etc.

> 	Am I write when I think that PCI subsystem ID 0x1017 is only
> the 1500 S card ????

I hope so. ;-)

> 	Wouldn't it be a good idea to start a README file in the ttpci tree
> which sums up the association PCI subsystem ID -> Full card name.
> I guess this does exists in the wiki or somewhere, but I didn't find
> it (to my great shame !)

http://linuxtv.org/wiki/index.php/Supported_DVB_cards
http://linuxtv.org/wiki/index.php/PCI_devices_DVB-S

It would be nice if you could add an entry for this card.
Thank you.

CU
Oliver

-- 
--------------------------------------------------------
VDR Remote Plugin available at
http://www.escape-edv.de/endriss/vdr/
--------------------------------------------------------