[linux-dvb] [PATCH] ir-keymaps.h misplaced and misnamed

Darren Salt linux at youmustbejoking.demon.co.uk
Wed Jan 18 01:36:12 CET 2006


I demand that Michael Krufky may or may not have written...

> Darren Salt wrote:
>> linux/include/media/ir-keymaps.h _defines_ some variables (as a header
>> file, it should only declare them) and is therefore misplaced and
>> misnamed. It should be linux/drivers/media/common/ir-keymaps.c.

>> (The corresponding declarations exist in ir-common.h and, I think, should
>> stay there.)
[snip]

> Wow... you certainly didnt waste any time..... ;-)

I wouldn't have noticed but for conflicts with a local patch set (which I'll
be posting within the next few days). It currently makes the default keymaps
smaller (done simply, but I'm planning some trivial compression), but doesn't
yet handle differently-sized keymaps at run-time.

[snip]
> On another note, this would have reached us a bit quicker had you written
> to the video4linux mailing list instead.

Subscribing...

> From a quick glance, it doesnt look to me as if DVB is using ir-common
> (yet) at all ...

Here, it is. ;-)

-- 
| Darren Salt | d youmustbejoking,demon,co,uk | nr. Ashington,
| Debian,     | s zap,tartarus,org            | Northumberland
| RISC OS     | @                             | Toon Army
|   I don't ask for much, just untold riches...

Even if you persuade me, you won't persuade me.



More information about the linux-dvb mailing list