[linux-dvb] Re: [FIX] v4l-algo: tuning broken in dvb_frontend where get_tune_settings is NULL

Manu Abraham abraham.manu at gmail.com
Sun Jun 25 13:03:25 CEST 2006


Michael Krufky wrote:
> Manu Abraham wrote:
>
>> Hello Mauro,
>>
>> Please pull from
>>
>> http://linuxtv.org/hg/~manu/v4l-algo?cmd=changeset;node=b0079105846d;style=gitweb 
>>
>>
>> Fix an Oops for all fe which have get_frontend_algo == NULL.
>>
>> Thanks to Johannes for pointing out the bug. 
>
> Manu,
>
> In your v4l-algo tree, changeset b0079105846d does indeed fix the 
> oops, however tuning is still broken.
> Joachim Steiger has pointed out a way to fix this.  Please see 
> changesets 75cfcb83e247 and b41adf921bb9 in my tree:
>
> http://linuxtv.org/hg/~mkrufky/v4l-algo
>
> Either we must fix this for all frontends, or dvb_frontend.c must be 
> fixed to prevent this problem.
>
> If you choose the former, then please pull from:
>
> http://linuxtv.org/hg/~mkrufky/v4l-algo
>
> for the following:
>
> - tda1004x: fixes that fe->ops.tuner_ops.set_params was not called anymore

set_frontend() is called from swzigzag and tuner set_params is called 
from within set_frontend. So it was indeed swzigzag not getting called. 
Have applied the fix now.

zig-zag is pointless for anything except for Satellite delivery. But 
anyway, that is not the point here. Anyway.


Manu




More information about the linux-dvb mailing list